From 5fbc9bd5e05a90ed1bc590a1c2f2bbbc04b1450f Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Fri, 24 Apr 2015 17:13:10 +1000 Subject: [PATCH] glimagesink: balance change_state display ref/unref the display was being unreffed on the incorrect state change causing invalid state when changing from PLAYING/PAUSED->READY->PAUSED/PLAYING. --- ext/gl/gstglimagesink.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ext/gl/gstglimagesink.c b/ext/gl/gstglimagesink.c index 1047616..796392d 100644 --- a/ext/gl/gstglimagesink.c +++ b/ext/gl/gstglimagesink.c @@ -968,15 +968,14 @@ gst_glimage_sink_change_state (GstElement * element, GstStateChange transition) gst_object_unref (glimage_sink->context); glimage_sink->context = NULL; } - + break; + } + case GST_STATE_CHANGE_READY_TO_NULL: if (glimage_sink->display) { gst_object_unref (glimage_sink->display); glimage_sink->display = NULL; } break; - } - case GST_STATE_CHANGE_READY_TO_NULL: - break; default: break; } -- 2.7.4