From 5f86ecba8e8ed4d8e6896b8940b5796a86200408 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Pouiller?= Date: Wed, 16 Feb 2022 10:31:11 +0100 Subject: [PATCH] staging: wfx: WF200 has no official SDIO IDs MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200 are official SDIO IDs. However, it is not the case, the values used by WF200 are not official (BTW, the driver rely on the DT rather than on the SDIO IDs to probe the device). To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use raw values. Reviewed-by: Pali Rohár Reviewed-by: Ulf Hansson Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20220216093112.92469-2-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wfx/bus_sdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c index bc3df85..312d2d3 100644 --- a/drivers/staging/wfx/bus_sdio.c +++ b/drivers/staging/wfx/bus_sdio.c @@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func) sdio_release_host(func); } -#define SDIO_VENDOR_ID_SILABS 0x0000 -#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 static const struct sdio_device_id wfx_sdio_ids[] = { - { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, + /* WF200 does not have official VID/PID */ + { SDIO_DEVICE(0x0000, 0x1000) }, { }, }; MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); -- 2.7.4