From 5eaf0b8ef0e0ad74e4c21cb6e688071a6cf8f66f Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Mon, 16 Apr 2012 11:27:11 -0300 Subject: [PATCH] Remove the Qt 5 todo about empty string lists in QSettings There's no need to change behaviour now. The current marker (@Invalid()) returns an empty string list, as opposed to a list with one item. Changing it would break compatibility unpredictably with Qt 4. So I choose not to change QSettings. Let it be "Done". Task-number: QTBUG-25110 Change-Id: Id1f353dfed800005d927183da237f3f8357c496d Reviewed-by: Oswald Buddenhagen Reviewed-by: Jason McDonald --- src/corelib/io/qsettings.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/corelib/io/qsettings.cpp b/src/corelib/io/qsettings.cpp index 1ec0390..8a6eef0 100644 --- a/src/corelib/io/qsettings.cpp +++ b/src/corelib/io/qsettings.cpp @@ -775,8 +775,6 @@ void QSettingsPrivate::iniEscapedStringList(const QStringList &strs, QByteArray with Qt 4.0. @Invalid() stands for QVariant(), and QVariant().toStringList() returns an empty QStringList, so we're in good shape. - - ### Qt 5: Use a nicer syntax, e.g. @List, for variant lists */ result += "@Invalid()"; } else { -- 2.7.4