From 5e8fc2f479c1e2f73f1454e11101657576f81d20 Mon Sep 17 00:00:00 2001 From: hj kim Date: Mon, 17 Sep 2018 15:23:07 +0900 Subject: [PATCH] Coverity issue fix Change-Id: I12fdb2170bb01586ccf7974fe20d6e2cfcd51ab0 --- src/media_controller_db.c | 1 + src/media_controller_metadata.c | 2 +- test/client_test/media_controller_client_test.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/media_controller_db.c b/src/media_controller_db.c index 945dd61..5b9640b 100755 --- a/src/media_controller_db.c +++ b/src/media_controller_db.c @@ -499,6 +499,7 @@ int mc_db_get_playback_info(void *handle, const char *server_name, mc_playback_h _playback = (media_controller_playback_s *)calloc(1, sizeof(media_controller_playback_s)); if (_playback == NULL) { mc_error("OUT_OF_MEMORY"); + MC_SAFE_FREE(playlist_name); MC_SAFE_FREE(index); return MEDIA_CONTROLLER_ERROR_OUT_OF_MEMORY; } diff --git a/src/media_controller_metadata.c b/src/media_controller_metadata.c index f5d7007..a54c8c8 100755 --- a/src/media_controller_metadata.c +++ b/src/media_controller_metadata.c @@ -243,7 +243,7 @@ int mc_search_destroy(mc_search_h search) length = g_list_length(mc_search->search_list); - for (idx = 0; idx > length; idx++) { + for (idx = 0; idx < length; idx++) { search_item = (mc_search_item_s*)g_list_nth_data(mc_search->search_list, idx); if (search_item != NULL) { diff --git a/test/client_test/media_controller_client_test.c b/test/client_test/media_controller_client_test.c index 7761de3..e01c214 100755 --- a/test/client_test/media_controller_client_test.c +++ b/test/client_test/media_controller_client_test.c @@ -209,6 +209,7 @@ void _mc_cmd_reply_received_cb(const char *server_name, const char *request_id, if (request_id == NULL) { mc_error("Invalid request_id"); + return; } for (i = 0; i < TEST_REQ_MAX; i++) { -- 2.7.4