From 5e3e97353de714eb748b83cc290a68c2ef5fb7cd Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Wed, 26 Nov 2014 15:59:36 +0100 Subject: [PATCH] isomp4: Fix mfro and tfra atom dumping mfro was skipping the version/flags tfra had wrong byte_reader return value checks --- gst/isomp4/qtdemux_dump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/isomp4/qtdemux_dump.c b/gst/isomp4/qtdemux_dump.c index 08425fd..749dbcc 100644 --- a/gst/isomp4/qtdemux_dump.c +++ b/gst/isomp4/qtdemux_dump.c @@ -568,6 +568,7 @@ qtdemux_dump_mfro (GstQTDemux * qtdemux, GstByteReader * data, int depth) if (!qt_atom_parser_has_remaining (data, 4)) return FALSE; + GST_LOG ("%*s version/flags: %08x", depth, "", GET_UINT32 (data)); GST_LOG ("%*s size: %d", depth, "", GET_UINT32 (data)); return TRUE; } @@ -596,8 +597,8 @@ qtdemux_dump_tfra (GstQTDemux * qtdemux, GstByteReader * data, int depth) GST_LOG ("%*s version/flags: %08x", depth, "", ver_flags); if (!gst_byte_reader_get_uint32_be (data, &track_id) || - gst_byte_reader_get_uint32_be (data, &len) || - gst_byte_reader_get_uint32_be (data, &num_entries)) + !gst_byte_reader_get_uint32_be (data, &len) || + !gst_byte_reader_get_uint32_be (data, &num_entries)) return FALSE; GST_LOG ("%*s track ID: %u", depth, "", track_id); -- 2.7.4