From 5df5c3f4cacf16c67c4b1493a3008b418ae98b2c Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Sun, 26 Aug 2012 23:43:26 +0100 Subject: [PATCH] eds: Remove unnecessary locking MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It didn’t achieve anything. --- backends/eds/lib/edsf-persona-store.vala | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/backends/eds/lib/edsf-persona-store.vala b/backends/eds/lib/edsf-persona-store.vala index 05cdc17..cce55f7 100644 --- a/backends/eds/lib/edsf-persona-store.vala +++ b/backends/eds/lib/edsf-persona-store.vala @@ -2099,17 +2099,15 @@ public class Edsf.PersonaStore : Folks.PersonaStore private void _contacts_added_cb (GLib.List contacts) { var added_personas = new HashSet (); - lock (this._personas) + + foreach (E.Contact c in contacts) { - foreach (E.Contact c in contacts) + var iid = Edsf.Persona.build_iid_from_contact (this.id, c); + if (this._personas.has_key (iid) == false) { - var iid = Edsf.Persona.build_iid_from_contact (this.id, c); - if (this._personas.has_key (iid) == false) - { - var persona = new Persona (this, c); - this._personas.set (persona.iid, persona); - added_personas.add (persona); - } + var persona = new Persona (this, c); + this._personas.set (persona.iid, persona); + added_personas.add (persona); } } -- 2.7.4