From 5dc8ffc724b8a2c2c3c1f3dbe8e1f8e58ee9d1ff Mon Sep 17 00:00:00 2001 From: Sangwan Kwon Date: Fri, 10 Jan 2020 15:58:37 +0900 Subject: [PATCH] Fix stringop-truncation warning Pathname sockets: The pathname in sun_path should be null-terminated. ref: http://man7.org/linux/man-pages/man7/unix.7.html Signed-off-by: Sangwan Kwon --- src/vist/rmi/impl/ondemand/socket.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vist/rmi/impl/ondemand/socket.cpp b/src/vist/rmi/impl/ondemand/socket.cpp index b995b18..110e3fc 100644 --- a/src/vist/rmi/impl/ondemand/socket.cpp +++ b/src/vist/rmi/impl/ondemand/socket.cpp @@ -58,7 +58,8 @@ Socket::Socket(const std::string& path) ::sockaddr_un addr; addr.sun_family = AF_UNIX; - ::strncpy(addr.sun_path, path.c_str(), sizeof(sockaddr_un::sun_path)); + ::strncpy(addr.sun_path, path.c_str(), sizeof(sockaddr_un::sun_path) - 1); + addr.sun_path[sizeof(sockaddr_un::sun_path) - 1] = '\0'; if (addr.sun_path[0] == '@') addr.sun_path[0] = '\0'; -- 2.7.4