From 5db2718ce48c497e317787caebacd019da59c3b0 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 4 Aug 2019 17:39:27 -0600 Subject: [PATCH] Remove readline hack from gdb_select As discussed on gdb-patches, this removes the readline hack from the mingw-hdep.c version of gdb_select. It's believed that this is not needed any more. See: https://sourceware.org/ml/gdb-patches/2019-03/msg00465.html gdb/ChangeLog 2019-08-12 Tom Tromey * mingw-hdep.c (gdb_select): Remove readline hack. --- gdb/ChangeLog | 4 ++++ gdb/mingw-hdep.c | 9 --------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4008783..e134155 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-08-12 Tom Tromey + + * mingw-hdep.c (gdb_select): Remove readline hack. + 2019-08-09 Pedro Franco de Carvalho * blockframe.c (find_pc_partial_function): Set *block to nullptr diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c index 8ed4b44..44fb22e 100644 --- a/gdb/mingw-hdep.c +++ b/gdb/mingw-hdep.c @@ -23,7 +23,6 @@ #include "event-loop.h" #include "gdb_select.h" -#include "readline/readline.h" #include @@ -167,14 +166,6 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, } } - /* With multi-threaded SIGINT handling, there is a race between the - readline signal handler and GDB. It may still be in - rl_prep_terminal in another thread. Do not return until it is - done; we can check the state here because we never longjmp from - signal handlers on Windows. */ - while (RL_ISSTATE (RL_STATE_SIGHANDLER)) - Sleep (1); - return num_ready; } -- 2.7.4