From 5d9ceefb82c0cd958e3ff435669348f05fe718fb Mon Sep 17 00:00:00 2001 From: Bowon Ryu Date: Wed, 18 Jan 2023 15:37:40 +0900 Subject: [PATCH] [NUI] fix tct block issue in text field and editor GetInputMethodContext() in ReleaseSwigCPtr crashes due to current changes in BaseHandle. Move DestroyContext() to Dispose to avoid this. Signed-off-by: Bowon Ryu --- src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs | 4 ++-- src/Tizen.NUI/src/public/BaseComponents/TextField.cs | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs b/src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs index bae253b..0220e89 100755 --- a/src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs +++ b/src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs @@ -2544,6 +2544,8 @@ namespace Tizen.NUI.BaseComponents } TextChanged -= TextEditorTextChanged; + GetInputMethodContext()?.DestroyContext(); + base.Dispose(type); } @@ -2551,8 +2553,6 @@ namespace Tizen.NUI.BaseComponents [EditorBrowsable(EditorBrowsableState.Never)] protected override void ReleaseSwigCPtr(System.Runtime.InteropServices.HandleRef swigCPtr) { - // In order to speed up IME hide, temporarily add - GetInputMethodContext()?.DestroyContext(); Interop.TextEditor.DeleteTextEditor(swigCPtr); } diff --git a/src/Tizen.NUI/src/public/BaseComponents/TextField.cs b/src/Tizen.NUI/src/public/BaseComponents/TextField.cs index 18d7162..bda1758 100755 --- a/src/Tizen.NUI/src/public/BaseComponents/TextField.cs +++ b/src/Tizen.NUI/src/public/BaseComponents/TextField.cs @@ -2550,6 +2550,7 @@ namespace Tizen.NUI.BaseComponents } TextChanged -= TextFieldTextChanged; + GetInputMethodContext()?.DestroyContext(); base.Dispose(type); } @@ -2558,8 +2559,6 @@ namespace Tizen.NUI.BaseComponents [EditorBrowsable(EditorBrowsableState.Never)] protected override void ReleaseSwigCPtr(System.Runtime.InteropServices.HandleRef swigCPtr) { - // In order to speed up IME hide, temporarily add - GetInputMethodContext()?.DestroyContext(); Interop.TextField.DeleteTextField(swigCPtr); } -- 2.7.4