From 5d51a65dcc7087ba2f5db5da3c16efbff3182cdc Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Wed, 4 May 2011 23:36:25 +0200 Subject: [PATCH] tests: add excerpts from few original bug reports, for clarity. * tests/comment6.test: Add excerpts and/or details from the original bug report that prompted this tests to be added and/or extended. * tests/dejagnu4.test: Likewise. * tests/installdir.test: Likewise. --- ChangeLog | 9 +++++++++ tests/comment6.test | 4 ++++ tests/dejagnu4.test | 6 ++++++ tests/installdir.test | 4 ++++ 4 files changed, 23 insertions(+) diff --git a/ChangeLog b/ChangeLog index 4b10c8e..cf2fc14 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2011-05-04 Stefano Lattarini + tests: add excerpts from few original bug reports, for clarity. + * tests/comment6.test: Add excerpts and/or details from the + original bug report that prompted this tests to be added and/or + extended. + * tests/dejagnu4.test: Likewise. + * tests/installdir.test: Likewise. + +2011-05-04 Stefano Lattarini + tests defs: allow requirements for compilers (mostly dummy) Most of the new requirements that are now accepted in `$required' as consequence of this patch are still dummy. They are planned diff --git a/tests/comment6.test b/tests/comment6.test index 0895768..1c46c86 100755 --- a/tests/comment6.test +++ b/tests/comment6.test @@ -15,6 +15,8 @@ # along with this program. If not, see . # Test for PR/322. +# Automake 1.6.1 seems to have a problem parsing comments that use +# '\' to span multiple lines. . ./defs || Exit 1 @@ -62,3 +64,5 @@ $AUTOMAKE $MAKE grep '# SOME_FILES' Makefile grep '# *file3' Makefile + +: diff --git a/tests/dejagnu4.test b/tests/dejagnu4.test index 0d6a1bd..02eb444 100755 --- a/tests/dejagnu4.test +++ b/tests/dejagnu4.test @@ -16,6 +16,12 @@ # Check that the DejaGnu rules work for a simple program and test case. # Also check PR 488: Failure of the first of several tools tested. +# From the original bug report: +# ``If you use dejagnu for testing and have multiple tools (i.e., +# multiple entries in the DEJATOOL variable) then the success/failure +# of "make check" is only dependent on the success/failure of the +# tests on the final tool. Thus there may be failures in the tests on +# previous tools, but at first glance "make check" has passed.'' required=runtest . ./defs || Exit 1 diff --git a/tests/installdir.test b/tests/installdir.test index ff4ced5..faa074d 100755 --- a/tests/installdir.test +++ b/tests/installdir.test @@ -15,6 +15,10 @@ # along with this program. If not, see . # Test for PR 203. +# == Report == +# Some standard targets are missing `-local' hooks. For instance, +# installdirs is missing this. Ideally this would be an automatic +# feature of any exported target. . ./defs || Exit 1 -- 2.7.4