From 5d0564d2e6206129464043e45301c6ef4e42359c Mon Sep 17 00:00:00 2001 From: Joey Gouly Date: Fri, 2 Aug 2013 19:18:12 +0000 Subject: [PATCH] [ARMv8] Add an assembler warning for the deprecated 'setend' instruction. llvm-svn: 187666 --- llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 12 ++++++++++++ llvm/test/MC/ARM/deprecated-v8.s | 3 +++ 2 files changed, 15 insertions(+) create mode 100644 llvm/test/MC/ARM/deprecated-v8.s diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index 8e56a1a..862e116 100644 --- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -229,6 +229,7 @@ class ARMAsmParser : public MCTargetAsmParser { SmallVectorImpl &Operands); bool shouldOmitPredicateOperand(StringRef Mnemonic, SmallVectorImpl &Operands); + bool isDeprecated(MCInst &Inst, StringRef &Info); public: enum ARMMatchResultTy { @@ -4876,6 +4877,13 @@ bool ARMAsmParser::shouldOmitPredicateOperand( return false; } +bool ARMAsmParser::isDeprecated(MCInst &Inst, StringRef &Info) { + if (hasV8Ops() && Inst.getOpcode() == ARM::SETEND) { + Info = "armv8"; + return true; + } +} + static bool isDataTypeToken(StringRef Tok) { return Tok == ".8" || Tok == ".16" || Tok == ".32" || Tok == ".64" || Tok == ".i8" || Tok == ".i16" || Tok == ".i32" || Tok == ".i64" || @@ -5376,6 +5384,10 @@ validateInstruction(MCInst &Inst, } } + StringRef DepInfo; + if (isDeprecated(Inst, DepInfo)) + Warning(Loc, "deprecated on " + DepInfo); + return false; } diff --git a/llvm/test/MC/ARM/deprecated-v8.s b/llvm/test/MC/ARM/deprecated-v8.s new file mode 100644 index 0000000..e509a35 --- /dev/null +++ b/llvm/test/MC/ARM/deprecated-v8.s @@ -0,0 +1,3 @@ +@ RUN: llvm-mc -triple armv8 -show-encoding < %s 2>&1 | FileCheck %s +setend be +@ CHECK: warning: deprecated on armv8 -- 2.7.4