From 5cf368b36c7bea3b39b5414ddb6b475560b76675 Mon Sep 17 00:00:00 2001 From: Arun Raghavan Date: Sun, 3 Sep 2017 15:23:10 +0530 Subject: [PATCH] dcaparse: Don't unmap buffer before accessing data from it The previous patch added a check for a substream header after gst_buffer_unmap(), which is incorrect. --- gst/audioparsers/gstdcaparse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gst/audioparsers/gstdcaparse.c b/gst/audioparsers/gstdcaparse.c index 3746eef..a31f9d3 100644 --- a/gst/audioparsers/gstdcaparse.c +++ b/gst/audioparsers/gstdcaparse.c @@ -446,9 +446,6 @@ gst_dca_parse_handle_frame (GstBaseParse * parse, gst_base_parse_set_frame_rate (parse, rate, block_size, 0, 0); } -cleanup: - gst_buffer_unmap (buf, &map); - /* it is possible that DTS HD substream after DTS core */ if (parse->flags & GST_BASE_PARSE_FLAG_DRAINING || map.size >= size + 9) { extra_size = 0; @@ -481,6 +478,9 @@ cleanup: ret = GST_FLOW_OK; } +cleanup: + gst_buffer_unmap (buf, &map); + return ret; } -- 2.7.4