From 5ce4f8059b9d85b985b08be562bba0f6ee553d15 Mon Sep 17 00:00:00 2001 From: "antonm@chromium.org" Date: Fri, 7 May 2010 10:56:22 +0000 Subject: [PATCH] Turn {mov,add}q into {mov,add}l. All the cases fixed are safe as registers hold 32-bit value, but that looks safer to operate on proper sizes. Review URL: http://codereview.chromium.org/2017002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4610 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/x64/codegen-x64.cc | 4 ++-- src/x64/stub-cache-x64.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc index 473fead..2f21357 100644 --- a/src/x64/codegen-x64.cc +++ b/src/x64/codegen-x64.cc @@ -4447,7 +4447,7 @@ void CodeGenerator::GenerateRegExpConstructResult(ZoneList* args) { __ Move(FieldOperand(rcx, HeapObject::kMapOffset), Factory::fixed_array_map()); // Set length. - __ movq(FieldOperand(rcx, FixedArray::kLengthOffset), rbx); + __ movl(FieldOperand(rcx, FixedArray::kLengthOffset), rbx); // Fill contents of fixed-array with the-hole. __ Move(rdx, Factory::the_hole_value()); __ lea(rcx, FieldOperand(rcx, FixedArray::kHeaderSize)); @@ -9010,7 +9010,7 @@ void ArgumentsAccessStub::GenerateNewObject(MacroAssembler* masm) { __ movq(FieldOperand(rax, JSObject::kElementsOffset), rdi); __ LoadRoot(kScratchRegister, Heap::kFixedArrayMapRootIndex); __ movq(FieldOperand(rdi, FixedArray::kMapOffset), kScratchRegister); - __ movq(FieldOperand(rdi, FixedArray::kLengthOffset), rcx); + __ movl(FieldOperand(rdi, FixedArray::kLengthOffset), rcx); // Copy the fixed array slots. Label loop; diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc index dbe1c28..384bca1 100644 --- a/src/x64/stub-cache-x64.cc +++ b/src/x64/stub-cache-x64.cc @@ -1194,7 +1194,7 @@ Object* CallStubCompiler::CompileArrayPushCall(Object* object, __ movq(rdx, Operand(rsp, (argc + 1) * kPointerSize)); // Increment element's and array's sizes. - __ addq(FieldOperand(rbx, FixedArray::kLengthOffset), + __ addl(FieldOperand(rbx, FixedArray::kLengthOffset), Immediate(kAllocationDelta)); __ movq(FieldOperand(rdx, JSArray::kLengthOffset), rax); -- 2.7.4