From 5caee2176ae79fb923de174bf229d9b75eb37add Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sun, 2 Jan 2022 22:01:07 +0000 Subject: [PATCH] Apply clang-tidy fixes for bugprone-argument-comment to MLIR ArithmeticOps.cpp (NFC) --- mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp b/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp index 98f6170..91cbf4bd 100644 --- a/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp +++ b/mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp @@ -905,7 +905,7 @@ OpFoldResult arith::UIToFPOp::fold(ArrayRef operands) { FloatType floatTy = getType().cast(); APFloat apf(floatTy.getFloatSemantics(), APInt::getZero(floatTy.getWidth())); - apf.convertFromAPInt(api, /*signed=*/false, APFloat::rmNearestTiesToEven); + apf.convertFromAPInt(api, /*IsSigned=*/false, APFloat::rmNearestTiesToEven); return FloatAttr::get(floatTy, apf); } return {}; @@ -925,7 +925,7 @@ OpFoldResult arith::SIToFPOp::fold(ArrayRef operands) { FloatType floatTy = getType().cast(); APFloat apf(floatTy.getFloatSemantics(), APInt::getZero(floatTy.getWidth())); - apf.convertFromAPInt(api, /*signed=*/true, APFloat::rmNearestTiesToEven); + apf.convertFromAPInt(api, /*IsSigned=*/true, APFloat::rmNearestTiesToEven); return FloatAttr::get(floatTy, apf); } return {}; @@ -943,7 +943,7 @@ OpFoldResult arith::FPToUIOp::fold(ArrayRef operands) { const APFloat &apf = lhs.getValue(); IntegerType intTy = getType().cast(); bool ignored; - APSInt api(intTy.getWidth(), /*unsigned=*/true); + APSInt api(intTy.getWidth(), /*isUnsigned=*/true); if (APFloat::opInvalidOp == apf.convertToInteger(api, APFloat::rmTowardZero, &ignored)) { // Undefined behavior invoked - the destination type can't represent @@ -969,7 +969,7 @@ OpFoldResult arith::FPToSIOp::fold(ArrayRef operands) { const APFloat &apf = lhs.getValue(); IntegerType intTy = getType().cast(); bool ignored; - APSInt api(intTy.getWidth(), /*unsigned=*/false); + APSInt api(intTy.getWidth(), /*isUnsigned=*/false); if (APFloat::opInvalidOp == apf.convertToInteger(api, APFloat::rmTowardZero, &ignored)) { // Undefined behavior invoked - the destination type can't represent -- 2.7.4