From 5ca9d8f086c5569a14a792ee55c75478496f2a8f Mon Sep 17 00:00:00 2001 From: Nicholas Clark Date: Fri, 30 Mar 2012 15:54:00 +0200 Subject: [PATCH] Remove "Remove duplication of test setup" from the todo list. It's no longer obvious which files in t/ contain significant amounts of setup code which is duplicated. Common cases of skip logic have already been moved into t/test.pl. The suggestion of replacing $Is_Foo checks with %Is is not a clear-cut win - each $Is_Foo eliminated is only a 1 line saving, at the cost of another testing idiom the future maintenance programmer has to become familiar with. The related suggestion "Migrate t/ from custom TAP generation" remains something to do. There are still various files in t/ which could use be converted to use the comparison functions of t/test.pl reducing code size, improving failure diagnostics and where this eliminates manual test counters, increasing flexibility for adding tests in the logically correct location within the file. --- Porting/todo.pod | 7 ------- 1 file changed, 7 deletions(-) diff --git a/Porting/todo.pod b/Porting/todo.pod index 130f5fa..c410c05 100644 --- a/Porting/todo.pod +++ b/Porting/todo.pod @@ -56,13 +56,6 @@ automated with a bit of perl, specifically the generation of See F for details. -=head2 Remove duplication of test setup. - -Schwern notes, that there's duplication of code - lots and lots of tests have -some variation on the big block of C<$Is_Foo> checks. We can safely put this -into a file, change it to build an C<%Is> hash and require it. Maybe just put -it into F. Throw in the handy tainting subroutines. - =head2 POD -E HTML conversion in the core still sucks Which is crazy given just how simple POD purports to be, and how simple HTML -- 2.7.4