From 5c70016eb3bb7b430ef912d422b3d2727c118336 Mon Sep 17 00:00:00 2001 From: Jim Cromie Date: Tue, 31 May 2011 10:47:29 -0600 Subject: [PATCH] perlhack.pod: invoke git-format-patch with --attach As George Greer noted on p5p, --attach causes the message to be written using MIME-attach syntax, so when perlbug sends it, rt.perl.org detaches the file and adds it to the ticket. While tradtional inline patches appear to survive without whitespace mangling, attachments are more in keeping with RTs design and use. Signed-off-by: Jim Cromie --- pod/perlhack.pod | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pod/perlhack.pod b/pod/perlhack.pod index f8f8bdd..6f5ea73 100644 --- a/pod/perlhack.pod +++ b/pod/perlhack.pod @@ -56,10 +56,11 @@ sentence. For example, "Fixed spelling errors in perlhack.pod". The next step is to submit your patch to the Perl core ticket system via email. -Assuming your patch consists of a single git commit, you can send it to -perlbug with this command line: +Assuming your patch consists of a single git commit, the following +writes the file as a MIME attachment, and sends it with a meaningful +subject: - % git format-patch -1 + % git format-patch -1 --attach % perlbug -s "[PATCH] $(git log -1 --oneline HEAD)" -f 0001-*.patch The perlbug program will ask you a few questions about your email -- 2.7.4