From 5c6b3ae6c6ab0d36f902518525af24276f0c68a1 Mon Sep 17 00:00:00 2001 From: "kmillikin@chromium.org" Date: Mon, 7 Mar 2011 12:08:51 +0000 Subject: [PATCH] Fix presubmit errors. TBR=whesse Review URL: http://codereview.chromium.org/6627049 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7075 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/hydrogen.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/hydrogen.cc b/src/hydrogen.cc index 1b66e64..158bfbe 100644 --- a/src/hydrogen.cc +++ b/src/hydrogen.cc @@ -3228,7 +3228,7 @@ void HGraphBuilder::HandlePolymorphicStoreNamedField(Assignment* expr, // Finish up. Unconditionally deoptimize if we've handled all the maps we // know about and do not want to handle ones we've never seen. Otherwise // use a generic IC. - if (count == types->length() && FLAG_deoptimize_uncommon_cases) { + if (count == types->length() && FLAG_deoptimize_uncommon_cases) { current_block()->FinishExit(new HDeoptimize); } else { HInstruction* instr = BuildStoreNamedGeneric(object, name, value); @@ -4447,13 +4447,15 @@ void HGraphBuilder::VisitCall(Call* expr) { } if (global_call) { + bool known_global_function = false; // If there is a global property cell for the name at compile time and // access check is not enabled we assume that the function will not change // and generate optimized code for calling the function. - bool known_global_function = info()->has_global_object() && - !info()->global_object()->IsAccessCheckNeeded() && - expr->ComputeGlobalTarget(Handle(info()->global_object()), - var->name()); + if (info()->has_global_object() && + !info()->global_object()->IsAccessCheckNeeded()) { + Handle global(info()->global_object()); + known_global_function = expr->ComputeGlobalTarget(global, var->name()); + } if (known_global_function) { // Push the global object instead of the global receiver because // code generated by the full code generator expects it. -- 2.7.4