From 5c090aa8637c13e434db7dc557d41664093a2817 Mon Sep 17 00:00:00 2001 From: Martin Kaiser Date: Mon, 10 Jan 2022 13:46:35 +0100 Subject: [PATCH] staging: r8188eu: relay errors from ODM_ReadAndConfig_... Most of the ODM_ReadAndConfig_... functions return an error status. Update their callers to process these return values. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20220110124638.6909-7-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c index 2f07524..5ec9a04 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -360,22 +360,22 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *dm_odm, enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm) { - ODM_ReadAndConfig_RadioA_1T_8188E(dm_odm); - - return HAL_STATUS_SUCCESS; + return ODM_ReadAndConfig_RadioA_1T_8188E(dm_odm); } enum HAL_STATUS ODM_ConfigBBWithHeaderFile(struct odm_dm_struct *dm_odm, enum odm_bb_config_type config_tp) { - if (config_tp == CONFIG_BB_PHY_REG) - ODM_ReadAndConfig_PHY_REG_1T_8188E(dm_odm); - else if (config_tp == CONFIG_BB_AGC_TAB) - ODM_ReadAndConfig_AGC_TAB_1T_8188E(dm_odm); - else if (config_tp == CONFIG_BB_PHY_REG_PG) + if (config_tp == CONFIG_BB_PHY_REG) { + return ODM_ReadAndConfig_PHY_REG_1T_8188E(dm_odm); + } else if (config_tp == CONFIG_BB_AGC_TAB) { + return ODM_ReadAndConfig_AGC_TAB_1T_8188E(dm_odm); + } else if (config_tp == CONFIG_BB_PHY_REG_PG) { ODM_ReadAndConfig_PHY_REG_PG_8188E(dm_odm); + return HAL_STATUS_SUCCESS; + } - return HAL_STATUS_SUCCESS; + return HAL_STATUS_FAILURE; } enum HAL_STATUS ODM_ConfigMACWithHeaderFile(struct odm_dm_struct *dm_odm) -- 2.7.4