From 5be2d776a174454310412b883e254bb6a5c2c0eb Mon Sep 17 00:00:00 2001 From: Jaewook Jung Date: Thu, 13 Apr 2017 14:55:15 +0900 Subject: [PATCH] Fix a defect detected by static code analyzer unsigned int is always greater than or equal to zero. Change-Id: I2aa83c4a224e5bbaf22882ccb131161850dcee57 Signed-off-by: Jaewook Jung Reviewed-on: https://gerrit.iotivity.org/gerrit/18879 Tested-by: jenkins-iotivity Reviewed-by: Jaehong Jo Reviewed-by: Dan Mihai Reviewed-by: Ashok Babu Channa --- resource/csdk/connectivity/src/cablockwisetransfer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resource/csdk/connectivity/src/cablockwisetransfer.c b/resource/csdk/connectivity/src/cablockwisetransfer.c index 21e16be..6cbcdc0 100644 --- a/resource/csdk/connectivity/src/cablockwisetransfer.c +++ b/resource/csdk/connectivity/src/cablockwisetransfer.c @@ -1923,7 +1923,7 @@ uint8_t CACheckBlockErrorType(CABlockData_t *currData, coap_block_t *receivedBlo OIC_LOG(ERROR, TAG, "too large size"); // set the block size to be smaller than COAP_MAX_PDU_SIZE - for (unsigned int size = CA_DEFAULT_BLOCK_SIZE; size >= 0; size--) + for (unsigned int size = CA_DEFAULT_BLOCK_SIZE; ; size--) { if (COAP_MAX_PDU_SIZE >= (size_t)BLOCK_SIZE(size) + optionLen) { @@ -1932,6 +1932,10 @@ uint8_t CACheckBlockErrorType(CABlockData_t *currData, coap_block_t *receivedBlo currData->block1.szx = size; break; } + if (0 == size) + { + break; + } } return CA_BLOCK_TOO_LARGE; } -- 2.7.4