From 5b89c87afbebbe3963f5e242d94cf2209e469522 Mon Sep 17 00:00:00 2001 From: Pawel Andruszkiewicz Date: Thu, 30 Apr 2015 15:00:07 +0200 Subject: [PATCH] [Download] Privilege checks moved to JS. Privileges need to be checked before validation of arguments. Change-Id: I4d137667f531a4ca8f4899ac3ef1d240c63eb9cb Signed-off-by: Pawel Andruszkiewicz --- src/download/download_api.js | 2 ++ src/download/download_instance.cc | 7 ------- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/download/download_api.js b/src/download/download_api.js index 96542b86..f8af8b3e 100644 --- a/src/download/download_api.js +++ b/src/download/download_api.js @@ -169,6 +169,8 @@ function DownloadManager() { } DownloadManager.prototype.start = function() { + xwalk.utils.checkPrivilegeAccess(xwalk.utils.privilege.DOWNLOAD); + var args = validator_.validateArgs(arguments, [ {'name' : 'downloadRequest', 'type': types_.PLATFORM_OBJECT, 'values': tizen.DownloadRequest}, {'name' : 'downloadCallback', 'type': types_.LISTENER, diff --git a/src/download/download_instance.cc b/src/download/download_instance.cc index a32381a6..14d7d74f 100644 --- a/src/download/download_instance.cc +++ b/src/download/download_instance.cc @@ -20,12 +20,6 @@ namespace download { std::vector DownloadInstance::instances_; std::mutex DownloadInstance::instances_mutex_; -namespace { -// The privileges that required in Download API -const std::string kPrivilegeDownload = "http://tizen.org/privilege/download"; - -} // namespace - using common::NotFoundException; using common::UnknownException; using common::NetworkException; @@ -370,7 +364,6 @@ void DownloadInstance::progress_changed_cb void DownloadInstance::DownloadManagerStart (const picojson::value& args, picojson::object& out) { - CHECK_PRIVILEGE_ACCESS(kPrivilegeDownload, &out); CHECK_EXIST(args, "callbackId", out) int ret, downlodId; -- 2.34.1