From 5b841c4a64e338d0d0710422ed6ec5821f6cd43a Mon Sep 17 00:00:00 2001 From: Shuxin Yang Date: Wed, 19 Dec 2012 01:10:17 +0000 Subject: [PATCH] Make sure the buffer, which containas an instance of APFloat, has proper alignment. llvm-svn: 170486 --- llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp index bd642de..30d7534 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp @@ -65,11 +65,11 @@ namespace { private: bool insaneIntVal(int V) { return V > 4 || V < -4; } APFloat *getFpValPtr(void) - { return reinterpret_cast(&FpValBuf[0]); } + { return reinterpret_cast(&FpValBuf.buffer[0]); } const APFloat &getFpVal(void) const { assert(IsFp && BufHasFpVal && "Incorret state"); - return *reinterpret_cast(&FpValBuf[0]); + return *reinterpret_cast(&FpValBuf.buffer[0]); } APFloat &getFpVal(void) @@ -78,6 +78,7 @@ namespace { bool isInt() const { return !IsFp; } private: + bool IsFp; // True iff FpValBuf contains an instance of APFloat. @@ -88,11 +89,8 @@ namespace { // two instructions. So the range of falls in [-4, 4]. APInt // is overkill of this end. short IntVal; - - union { - char FpValBuf[sizeof(APFloat)]; - int dummy; // So this structure has at least 4-byte alignment. - }; + + AlignedCharArrayUnion FpValBuf; }; /// FAddend is used to represent floating-point addend. An addend is -- 2.7.4