From 5b3da067f0893be637f9e992b409e36682ea081a Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 11 Jan 2016 14:05:11 -0500 Subject: [PATCH] gdbserver: fix various warnings Delete unused funcs, update old prototypes, and mark local funcs as static. This doesn't cover all missing prototype warnings. --- gdb/gdbserver/ChangeLog | 13 +++++++++++++ gdb/gdbserver/ax.c | 2 +- gdb/gdbserver/linux-low.c | 6 +++--- gdb/gdbserver/mem-break.c | 4 ++-- gdb/gdbserver/regcache.c | 12 ------------ gdb/gdbserver/remote-utils.c | 2 +- gdb/gdbserver/server.c | 12 ++++++------ 7 files changed, 26 insertions(+), 25 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index e277348..cbb7d28 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,16 @@ +2016-01-12 Mike Frysinger + + * ax.c (is_goto_target): Mark static. + * linux-low.c (register_addr): Likewise. + (linux_fetch_registers, linux_store_registers): Likewise. + * mem-break.c (any_persistent_commands): Fix old prototype. + (add_commands_to_breakpoint): Mark static. + * regcache.c (find_register_by_name): Delete unused func. + * remote-utils.c (hex_or_minus_one): Mark static. + * server.c (monitor_show_help): Mark static. + (handle_query, handle_v_cont, handle_v_attach, handle_v_kill, + handle_v_requests): Likewise. + 2016-01-12 Pedro Alves Remove use of the registered trademark symbol throughout. diff --git a/gdb/gdbserver/ax.c b/gdb/gdbserver/ax.c index 91894c2..d5144c2 100644 --- a/gdb/gdbserver/ax.c +++ b/gdb/gdbserver/ax.c @@ -375,7 +375,7 @@ emit_le_goto (int *offset_p, int *size_p) /* Scan an agent expression for any evidence that the given PC is the target of a jump bytecode in the expression. */ -int +static int is_goto_target (struct agent_expr *aexpr, int pc) { int i; diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index fe3ba85..47f0f9d 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -5227,7 +5227,7 @@ linux_register_in_regsets (const struct regs_info *regs_info, int regno) #ifdef HAVE_LINUX_USRREGS -int +static int register_addr (const struct usrregs_info *usrregs, int regnum) { int addr; @@ -5389,7 +5389,7 @@ usr_store_inferior_registers (const struct regs_info *regs_info, #endif -void +static void linux_fetch_registers (struct regcache *regcache, int regno) { int use_regsets; @@ -5422,7 +5422,7 @@ linux_fetch_registers (struct regcache *regcache, int regno) } } -void +static void linux_store_registers (struct regcache *regcache, int regno) { int use_regsets; diff --git a/gdb/gdbserver/mem-break.c b/gdb/gdbserver/mem-break.c index 2e220b8..b06f8e9 100644 --- a/gdb/gdbserver/mem-break.c +++ b/gdb/gdbserver/mem-break.c @@ -267,7 +267,7 @@ Z_packet_to_raw_bkpt_type (char z_type) } int -any_persistent_commands () +any_persistent_commands (void) { struct process_info *proc = current_process (); struct breakpoint *bp; @@ -1269,7 +1269,7 @@ gdb_condition_true_at_breakpoint (CORE_ADDR where) /* Add commands COMMANDS to GDBserver's breakpoint BP. */ -void +static void add_commands_to_breakpoint (struct breakpoint *bp, struct agent_expr *commands, int persist) { diff --git a/gdb/gdbserver/regcache.c b/gdb/gdbserver/regcache.c index cd8d9db..6a737ea 100644 --- a/gdb/gdbserver/regcache.c +++ b/gdb/gdbserver/regcache.c @@ -253,18 +253,6 @@ registers_from_string (struct regcache *regcache, char *buf) hex2bin (buf, registers, len / 2); } -struct reg * -find_register_by_name (const struct target_desc *tdesc, const char *name) -{ - int i; - - for (i = 0; i < tdesc->num_registers; i++) - if (strcmp (name, tdesc->reg_defs[i].name) == 0) - return &tdesc->reg_defs[i]; - internal_error (__FILE__, __LINE__, "Unknown register %s requested", - name); -} - int find_regno (const struct target_desc *tdesc, const char *name) { diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c index c5f4647..40bd373 100644 --- a/gdb/gdbserver/remote-utils.c +++ b/gdb/gdbserver/remote-utils.c @@ -526,7 +526,7 @@ write_ptid (char *buf, ptid_t ptid) return buf; } -ULONGEST +static ULONGEST hex_or_minus_one (char *buf, char **obuf) { ULONGEST ret; diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 61b164b..440c076 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -805,7 +805,7 @@ get_features_xml (const char *annex) return NULL; } -void +static void monitor_show_help (void) { monitor_output ("The following monitor commands are supported:\n"); @@ -1966,7 +1966,7 @@ supported_btrace_packets (char *buf) /* Handle all of the extended 'q' packets. */ -void +static void handle_query (char *own_buf, int packet_len, int *new_packet_len_p) { static struct inferior_list_entry *thread_ptr; @@ -2568,7 +2568,7 @@ handle_pending_status (const struct thread_resume *resumption, } /* Parse vCont packets. */ -void +static void handle_v_cont (char *own_buf) { char *p, *q; @@ -2735,7 +2735,7 @@ resume (struct thread_resume *actions, size_t num_actions) } /* Attach to a new program. Return 1 if successful, 0 if failure. */ -int +static int handle_v_attach (char *own_buf) { int pid; @@ -2858,7 +2858,7 @@ handle_v_run (char *own_buf) } /* Kill process. Return 1 if successful, 0 if failure. */ -int +static int handle_v_kill (char *own_buf) { int pid; @@ -2884,7 +2884,7 @@ handle_v_kill (char *own_buf) } /* Handle all of the extended 'v' packets. */ -void +static void handle_v_requests (char *own_buf, int packet_len, int *new_packet_len) { if (!disable_packet_vCont) -- 2.7.4