From 5b06661e2a91fba6b0923dbe047828fecfbce85f Mon Sep 17 00:00:00 2001 From: Minje Ahn Date: Mon, 31 Jul 2017 11:35:49 +0900 Subject: [PATCH] [ACR] Deprecate API that is paired with media_info_set_author author information is user data. Therefore, the get function is not needed if the set function does not exist. (media_info_set_author() is deprecated since 4.0) Change-Id: Ie00cb7a57891e202eb82b978de055091df173f01 Signed-off-by: Minje Ahn --- include/media_content_type.h | 4 +++- include/media_info.h | 3 ++- include_product/media_content_type.h | 4 +++- include_product/media_info.h | 3 ++- src/media_info.c | 1 + 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/include/media_content_type.h b/include/media_content_type.h index a33866a..d08c146 100755 --- a/include/media_content_type.h +++ b/include/media_content_type.h @@ -173,7 +173,7 @@ typedef enum { MEDIA_CONTENT_GROUP_ALTITUDE, /**< Media group ID for the altitude*/ MEDIA_CONTENT_GROUP_BURST_IMAGE, /**< Media group ID for the burst shot*/ MEDIA_CONTENT_GROUP_RATING, /**< Media group ID for a rating*/ - MEDIA_CONTENT_GROUP_AUTHOR, /**< Media group ID for an author*/ + MEDIA_CONTENT_GROUP_AUTHOR, /**< Media group ID for an author (Deprecated since 4.0)*/ MEDIA_CONTENT_GROUP_PROVIDER, /**< Media group ID for a provider*/ MEDIA_CONTENT_GROUP_CONTENT_NAME, /**< Media group ID for the content name (Deprecated since 4.0)*/ MEDIA_CONTENT_GROUP_CATEGORY, /**< Media group ID for a category*/ @@ -970,6 +970,7 @@ typedef bool (*media_face_cb)(media_face_h face, void *user_data); #define MEDIA_FAVOURITE "MEDIA_FAVOURITE" /** + * @deprecated Deprecated since 4.0. * @brief Media author * @details You can use above define to set the condition of media filter and order keyword. * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif @@ -1160,6 +1161,7 @@ typedef bool (*media_face_cb)(media_face_h face, void *user_data); #define MEDIA_DESCRIPTION_PINYIN "MEDIA_DESCRIPTION_PINYIN" /** + * @deprecated Deprecated since 4.0. * @brief Media author pinyin * @details You can use above define to set the condition of media filter and order keyword. * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif diff --git a/include/media_info.h b/include/media_info.h index b654ea8..c4a17a3 100755 --- a/include/media_info.h +++ b/include/media_info.h @@ -859,6 +859,7 @@ int media_info_get_rating(media_info_h media, int *rating); int media_info_get_favorite(media_info_h media, bool* favorite); /** + * @deprecated Deprecated since 4.0. * @brief Gets the author of content file. * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif * @@ -874,7 +875,7 @@ int media_info_get_favorite(media_info_h media, bool* favorite); * @retval #MEDIA_CONTENT_ERROR_OUT_OF_MEMORY Out of memory * @retval #MEDIA_CONTENT_ERROR_INVALID_PARAMETER Invalid parameter */ -int media_info_get_author(media_info_h media, char **author); +int media_info_get_author(media_info_h media, char **author) TIZEN_DEPRECATED_API; /** * @brief Gets the provider of content file which User set. diff --git a/include_product/media_content_type.h b/include_product/media_content_type.h index 594af75..f90f878 100755 --- a/include_product/media_content_type.h +++ b/include_product/media_content_type.h @@ -182,7 +182,7 @@ typedef enum { MEDIA_CONTENT_GROUP_ALTITUDE, /**< Media group ID for the altitude*/ MEDIA_CONTENT_GROUP_BURST_IMAGE, /**< Media group ID for the burst shot*/ MEDIA_CONTENT_GROUP_RATING, /**< Media group ID for a rating*/ - MEDIA_CONTENT_GROUP_AUTHOR, /**< Media group ID for an author*/ + MEDIA_CONTENT_GROUP_AUTHOR, /**< Media group ID for an author (Deprecated since 4.0)*/ MEDIA_CONTENT_GROUP_PROVIDER, /**< Media group ID for a provider*/ MEDIA_CONTENT_GROUP_CONTENT_NAME, /**< Media group ID for the content name (Deprecated since 4.0)*/ MEDIA_CONTENT_GROUP_CATEGORY, /**< Media group ID for a category*/ @@ -1036,6 +1036,7 @@ typedef bool (*media_face_cb)(media_face_h face, void *user_data); #define MEDIA_FAVOURITE "MEDIA_FAVOURITE" /** + * @deprecated Deprecated since 4.0. * @brief Media author * @details You can use above define to set the condition of media filter and order keyword. * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif @@ -1226,6 +1227,7 @@ typedef bool (*media_face_cb)(media_face_h face, void *user_data); #define MEDIA_DESCRIPTION_PINYIN "MEDIA_DESCRIPTION_PINYIN" /** + * @deprecated Deprecated since 4.0. * @brief Media author pinyin * @details You can use above define to set the condition of media filter and order keyword. * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif diff --git a/include_product/media_info.h b/include_product/media_info.h index b654ea8..c4a17a3 100755 --- a/include_product/media_info.h +++ b/include_product/media_info.h @@ -859,6 +859,7 @@ int media_info_get_rating(media_info_h media, int *rating); int media_info_get_favorite(media_info_h media, bool* favorite); /** + * @deprecated Deprecated since 4.0. * @brief Gets the author of content file. * @since_tizen @if MOBILE 2.3 @elseif WEARABLE 2.3.1 @endif * @@ -874,7 +875,7 @@ int media_info_get_favorite(media_info_h media, bool* favorite); * @retval #MEDIA_CONTENT_ERROR_OUT_OF_MEMORY Out of memory * @retval #MEDIA_CONTENT_ERROR_INVALID_PARAMETER Invalid parameter */ -int media_info_get_author(media_info_h media, char **author); +int media_info_get_author(media_info_h media, char **author) TIZEN_DEPRECATED_API; /** * @brief Gets the provider of content file which User set. diff --git a/src/media_info.c b/src/media_info.c index c4459ba..660255b 100755 --- a/src/media_info.c +++ b/src/media_info.c @@ -2019,6 +2019,7 @@ int media_info_get_favorite(media_info_h media, bool* favorite) int media_info_get_author(media_info_h media, char **author) { int ret = MEDIA_CONTENT_ERROR_NONE; + media_content_warn("DEPRECATION WARNING: media_info_get_author() is deprecated and will be removed from next release."); media_info_s *_media = (media_info_s*)media; if (_media && author) { -- 2.7.4