From 5b015250ba0da4e44b563724852a99f34acf41ba Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 13 Aug 2014 12:37:08 +0300 Subject: [PATCH] element: Clarify docs about gst_element_get_request_pad() and remove deprecation part This function is not really pad or slow for the common case of requesting a pad with the name of the template. It is only slower if you to name your pads directly instead of letting the element handle it. Also there's no reason to deprecate it in favor of a more complicated function for the common case. --- gst/gstelement.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gst/gstelement.c b/gst/gstelement.c index 3fbe7fe..3d8f7f6 100644 --- a/gst/gstelement.c +++ b/gst/gstelement.c @@ -975,8 +975,9 @@ _gst_element_request_pad (GstElement * element, GstPadTemplate * templ, * retrieves request pads. The pad should be released with * gst_element_release_request_pad(). * - * This method is slow and will be deprecated in the future. New code should - * use gst_element_request_pad() with the requested template. + * This method is slower than manually getting the pad template and calling + * gst_element_request_pad() if the pads should have a specific name (e.g. + * @name is "src_1" instead of "src_%u"). * * Returns: (transfer full) (nullable): requested #GstPad if found, * otherwise %NULL. Release after usage. -- 2.7.4