From 5ae881f96f999aaca98d8f83d3f00e037c783647 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 28 Oct 2019 15:01:27 -0700 Subject: [PATCH] [Docs] Repurpose 'sources' page as 'contributing'. The page describing how to get the sources was more about contributing to LLDB than getting the actual source. This patch moves some things around and repurposes this page as a contributing to LLDB landing page. --- lldb/docs/.htaccess | 4 ++- lldb/docs/index.rst | 4 +-- lldb/docs/resources/build.rst | 14 +++++++-- .../resources/{source.rst => contributing.rst} | 35 ++++++++++++---------- 4 files changed, 36 insertions(+), 21 deletions(-) rename lldb/docs/resources/{source.rst => contributing.rst} (77%) diff --git a/lldb/docs/.htaccess b/lldb/docs/.htaccess index aa63b1e..cc92b0a 100644 --- a/lldb/docs/.htaccess +++ b/lldb/docs/.htaccess @@ -6,6 +6,8 @@ Redirect 301 /goals.html https://lldb.llvm.org/status/goals.html Redirect 301 /lldb-gdb.html https://lldb.llvm.org/use/map.html Redirect 301 /projects.html https://lldb.llvm.org/status/projects.html Redirect 301 /remote.html https://lldb.llvm.org/use/remote.html -Redirect 301 /source.html https://lldb.llvm.org/resources/source.html +Redirect 301 /source.html https://lldb.llvm.org/resources/contributing.html Redirect 301 /tutorial.html https://lldb.llvm.org/use/tutorial.html Redirect 301 /varformats.html https://lldb.llvm.org/use/variable.html + +Redirect 301 /resources/source.html https://lldb.llvm.org/resources/contributing.html diff --git a/lldb/docs/index.rst b/lldb/docs/index.rst index faabed9..b833821 100644 --- a/lldb/docs/index.rst +++ b/lldb/docs/index.rst @@ -138,12 +138,12 @@ interesting areas to contribute to lldb. :maxdepth: 1 :caption: Resources - resources/download - resources/source + resources/contributing resources/build resources/test resources/bots resources/sbapi + resources/download .. toctree:: :hidden: diff --git a/lldb/docs/resources/build.rst b/lldb/docs/resources/build.rst index ec938f4..dabd224 100644 --- a/lldb/docs/resources/build.rst +++ b/lldb/docs/resources/build.rst @@ -1,9 +1,19 @@ -Build -===== +Building +======== .. contents:: :local: +Getting the Sources +------------------- + +Please refer to the `LLVM Getting Started Guide +`_ for +general instructions on how to check out the LLVM monorepo, which contains the +LLDB sources. + +Git browser: https://github.com/llvm/llvm-project/tree/master/lldb + Preliminaries ------------- diff --git a/lldb/docs/resources/source.rst b/lldb/docs/resources/contributing.rst similarity index 77% rename from lldb/docs/resources/source.rst rename to lldb/docs/resources/contributing.rst index 0216d30..4305cdc 100644 --- a/lldb/docs/resources/source.rst +++ b/lldb/docs/resources/contributing.rst @@ -1,17 +1,14 @@ -Getting the Sources -=================== +Contributing +============ -Refer to the `LLVM Getting Started Guide -`_ -for general instructions on how to check out source. Note that LLDB -depends on having a working checkout of LLVM and Clang, so the first -step is to download and build as described at the above URL. The same -repository also contains LLDB. +Getting Started +--------------- -Git browser: https://github.com/llvm/llvm-project/tree/master/lldb - -Refer to the `Build Instructions `_ for more detailed instructions -on how to build for a particular platform / build system combination. +Please refer to the `LLVM Getting Started Guide +`_ for general information on how to +get started on the LLVM project. A detailed explanation on how to build and +test LLDB can be found in the `build instructions `_ and `test +instructions `_ respecitvely. Contributing to LLDB -------------------- @@ -21,10 +18,16 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. -Test infrastructure. It is still important to submit tests with your -patches, but LLDB uses a different system for tests. Refer to the -`lldb/test` folder on disk for examples of how to write tests. For -anything not explicitly listed here, assume that LLDB follows the LLVM + - **Test infrastructure**: Like LLVM it is important to submit tests with your + patches, but note that LLDB uses a different system for tests. Refer to the + `test documentation `_ for more details and the `lldb/test` + folder on disk for examples. + + - **Coding Style**: LLDB's code style differs from LLVM's coding style. + Unfortunately there is no document describing the different. Please be + consistent with the existing code. + +For anything not explicitly listed here, assume that LLDB follows the LLVM policy. -- 2.7.4