From 5ae773e413db0809612a3dd6850d0d26551ccf68 Mon Sep 17 00:00:00 2001 From: jason Date: Thu, 18 Feb 2016 05:08:02 +0000 Subject: [PATCH] PR c++/68585 * constexpr.c (cxx_eval_bare_aggregate): Fix 'changed' detection. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@233513 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/cp/ChangeLog | 3 ++ gcc/cp/constexpr.c | 3 +- gcc/testsuite/g++.dg/cpp0x/constexpr-initlist9.C | 41 ++++++++++++++++++++++++ 3 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/constexpr-initlist9.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index c560375..963ba5a 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,5 +1,8 @@ 2016-02-17 Jason Merrill + PR c++/68585 + * constexpr.c (cxx_eval_bare_aggregate): Fix 'changed' detection. + PR c++/68679 * decl2.c (reset_type_linkage_2): Look through member templates. diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c index 11037fb..0eedfca 100644 --- a/gcc/cp/constexpr.c +++ b/gcc/cp/constexpr.c @@ -2234,6 +2234,7 @@ cxx_eval_bare_aggregate (const constexpr_ctx *ctx, tree t, bool side_effects_p = false; FOR_EACH_CONSTRUCTOR_ELT (v, i, index, value) { + tree orig_value = value; constexpr_ctx new_ctx; init_subob_ctx (ctx, new_ctx, index, value); if (new_ctx.ctor != ctx->ctor) @@ -2246,7 +2247,7 @@ cxx_eval_bare_aggregate (const constexpr_ctx *ctx, tree t, /* Don't VERIFY_CONSTANT here. */ if (ctx->quiet && *non_constant_p) break; - if (elt != value) + if (elt != orig_value) changed = true; if (!TREE_CONSTANT (elt)) diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-initlist9.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-initlist9.C new file mode 100644 index 0000000..239b91e --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-initlist9.C @@ -0,0 +1,41 @@ +// PR c++/68585 +// { dg-do compile { target c++11 } } + +template + struct array + { + T _M_data[N]; + }; + +template + struct integer_sequence + { + }; + +struct Pos +{ + unsigned l; +}; + +template +constexpr array make_grid_position(integer_sequence) +{ + return {{ Pos{Ints}... }}; +} + +constexpr array make_grid_positions() +{ + return make_grid_position(integer_sequence{}); +} + +template +void generate_sudoku(T) +{ + constexpr auto positions = make_grid_positions(); // fail +} + +int main() +{ + constexpr auto positions = make_grid_positions(); // ok + generate_sudoku(1); +} -- 2.7.4