From 5ab5113f6f401584f8ab053f098c2fb7340699d3 Mon Sep 17 00:00:00 2001 From: Hyunjun Ko Date: Fri, 12 May 2017 13:08:30 +0900 Subject: [PATCH] vaapisink: keep handle_events flag except that if user want to set When state of vaapisink is changed from PLAYING to NULL, the handle_events flag is set to FALSE, and never recovered, and then event thread is never going to run. So we should allow to set the flag only when users try it. https://bugzilla.gnome.org/show_bug.cgi?id=782543 --- gst/vaapi/gstvaapisink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/vaapi/gstvaapisink.c b/gst/vaapi/gstvaapisink.c index 013a469..d01c727 100644 --- a/gst/vaapi/gstvaapisink.c +++ b/gst/vaapi/gstvaapisink.c @@ -588,6 +588,7 @@ gst_vaapisink_video_overlay_set_event_handling (GstVideoOverlay * overlay, { GstVaapiSink *const sink = GST_VAAPISINK (overlay); + sink->handle_events = handle_events; gst_vaapisink_set_event_handling (sink, handle_events); } @@ -934,7 +935,6 @@ gst_vaapisink_set_event_handling (GstVaapiSink * sink, gboolean handle_events) return; GST_OBJECT_LOCK (sink); - sink->handle_events = handle_events; if (handle_events && !sink->event_thread) { /* Setup our event listening thread */ GST_DEBUG ("starting xevent thread"); -- 2.7.4