From 5a6307f9138efe4a0ec4f474572b828e9410e334 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Sat, 9 Feb 2019 17:25:03 -0300 Subject: [PATCH] validate:launcher: Do not sort tests all the time Do it once only once it is fully populated --- validate/launcher/baseclasses.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/validate/launcher/baseclasses.py b/validate/launcher/baseclasses.py index 419b025..7e351f3 100644 --- a/validate/launcher/baseclasses.py +++ b/validate/launcher/baseclasses.py @@ -1203,11 +1203,9 @@ class TestsManager(Loggable): if self._is_test_wanted(test): if test not in self.tests: self.tests.append(test) - self.tests.sort(key=lambda test: test.classname) else: if test not in self.tests: self.unwanted_tests.append(test) - self.unwanted_tests.sort(key=lambda test: test.classname) def get_tests(self): return self.tests @@ -1692,7 +1690,8 @@ class _TestsLauncher(Loggable): raise RuntimeError("Unexpected new test in testsuite.") self.tests.extend(tests) - return sorted(list(self.tests), key=lambda t: t.classname) + self.tests.sort(key=lambda test: test.classname) + return self.tests def _tester_needed(self, tester): for testsuite in self.options.testsuites: -- 2.7.4