From 5a322ed4327cb1e100ef39ba7900e75bc5010364 Mon Sep 17 00:00:00 2001 From: Thomas Vander Stichele Date: Tue, 20 Apr 2004 16:25:41 +0000 Subject: [PATCH] making _set_property warn on unknown properties use GST_TIME_FORMAT for timestamp/duration Original commit message from CVS: making _set_property warn on unknown properties use GST_TIME_FORMAT for timestamp/duration --- ChangeLog | 14 ++++++++++++++ gst/elements/gstfakesink.c | 7 ++++--- gst/elements/gstfakesrc.c | 1 + gst/elements/gstfdsrc.c | 1 + gst/elements/gstfilesrc.c | 1 + gst/elements/gstidentity.c | 5 +++-- gst/elements/gstmultifilesrc.c | 1 + gst/elements/gstpipefilter.c | 1 + plugins/elements/gstfakesink.c | 7 ++++--- plugins/elements/gstfakesrc.c | 1 + plugins/elements/gstfdsrc.c | 1 + plugins/elements/gstfilesrc.c | 1 + plugins/elements/gstidentity.c | 5 +++-- plugins/elements/gstmultifilesrc.c | 1 + plugins/elements/gstpipefilter.c | 1 + 15 files changed, 38 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index c92ab0e..dd4fc00 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,6 +9,20 @@ 2004-04-20 Thomas Vander Stichele + * gst/elements/gstfakesink.c: (gst_fakesink_state_error_get_type), + (gst_fakesink_set_property), (gst_fakesink_chain): + * gst/elements/gstfakesrc.c: (gst_fakesrc_set_property): + * gst/elements/gstfdsrc.c: (gst_fdsrc_set_property): + * gst/elements/gstfilesrc.c: (gst_filesrc_set_property): + * gst/elements/gstidentity.c: (gst_identity_chain), + (gst_identity_set_property): + * gst/elements/gstmultifilesrc.c: (gst_multifilesrc_set_property): + * gst/elements/gstpipefilter.c: (gst_pipefilter_set_property): + add warnings to _set_property for unknown arguments + use GST_TIME_FORMAT/GST_TIME_ARGS for timestamp printing + +2004-04-20 Thomas Vander Stichele + * Makefile.am: * docs/manuals.mak: add .po file download snippet diff --git a/gst/elements/gstfakesink.c b/gst/elements/gstfakesink.c index 6778cfb..a1c3eae 100644 --- a/gst/elements/gstfakesink.c +++ b/gst/elements/gstfakesink.c @@ -255,6 +255,7 @@ gst_fakesink_set_property (GObject * object, guint prop_id, sink->signal_handoffs = g_value_get_boolean (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } @@ -346,10 +347,10 @@ gst_fakesink_chain (GstPad * pad, GstData * _data) fakesink->last_message = g_strdup_printf ("chain ******* (%s:%s)< (%d bytes, timestamp: %" - G_GINT64_FORMAT ", duration: %" G_GINT64_FORMAT ", offset: %" + GST_TIME_FORMAT ", duration: %" GST_TIME_FORMAT ", offset: %" G_GINT64_FORMAT ", flags: %d) %p", GST_DEBUG_PAD_NAME (pad), - GST_BUFFER_SIZE (buf), GST_BUFFER_TIMESTAMP (buf), - GST_BUFFER_DURATION (buf), GST_BUFFER_OFFSET (buf), + GST_BUFFER_SIZE (buf), GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buf)), + GST_TIME_ARGS (GST_BUFFER_DURATION (buf)), GST_BUFFER_OFFSET (buf), GST_BUFFER_FLAGS (buf), buf); g_object_notify (G_OBJECT (fakesink), "last_message"); diff --git a/gst/elements/gstfakesrc.c b/gst/elements/gstfakesrc.c index c9a44f7..00aea94 100644 --- a/gst/elements/gstfakesrc.c +++ b/gst/elements/gstfakesrc.c @@ -535,6 +535,7 @@ gst_fakesrc_set_property (GObject * object, guint prop_id, const GValue * value, src->dump = g_value_get_boolean (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/gst/elements/gstfdsrc.c b/gst/elements/gstfdsrc.c index ff884f5..11fafdf 100644 --- a/gst/elements/gstfdsrc.c +++ b/gst/elements/gstfdsrc.c @@ -148,6 +148,7 @@ gst_fdsrc_set_property (GObject * object, guint prop_id, const GValue * value, src->timeout = g_value_get_uint64 (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/gst/elements/gstfilesrc.c b/gst/elements/gstfilesrc.c index 1943b24..6ef3783 100644 --- a/gst/elements/gstfilesrc.c +++ b/gst/elements/gstfilesrc.c @@ -322,6 +322,7 @@ gst_filesrc_set_property (GObject * object, guint prop_id, const GValue * value, g_object_notify (G_OBJECT (src), "touch"); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/gst/elements/gstidentity.c b/gst/elements/gstidentity.c index 0849361..cecf0ad 100644 --- a/gst/elements/gstidentity.c +++ b/gst/elements/gstidentity.c @@ -214,8 +214,8 @@ gst_identity_chain (GstPad * pad, GstData * _data) g_free (identity->last_message); identity->last_message = g_strdup_printf ("chain ******* (%s:%s)i (%d bytes, %" - G_GINT64_FORMAT ")", GST_DEBUG_PAD_NAME (identity->sinkpad), - GST_BUFFER_SIZE (buf), GST_BUFFER_TIMESTAMP (buf)); + GST_TIME_FORMAT ")", GST_DEBUG_PAD_NAME (identity->sinkpad), + GST_BUFFER_SIZE (buf), GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buf))); g_object_notify (G_OBJECT (identity), "last-message"); } @@ -299,6 +299,7 @@ gst_identity_set_property (GObject * object, guint prop_id, identity->drop_probability = g_value_get_float (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/gst/elements/gstmultifilesrc.c b/gst/elements/gstmultifilesrc.c index 156771a..7855efc 100644 --- a/gst/elements/gstmultifilesrc.c +++ b/gst/elements/gstmultifilesrc.c @@ -157,6 +157,7 @@ gst_multifilesrc_set_property (GObject * object, guint prop_id, } break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/gst/elements/gstpipefilter.c b/gst/elements/gstpipefilter.c index ec5d887..c141186 100644 --- a/gst/elements/gstpipefilter.c +++ b/gst/elements/gstpipefilter.c @@ -237,6 +237,7 @@ gst_pipefilter_set_property (GObject * object, guint prop_id, pipefilter->command = g_strsplit (g_value_get_string (value), " ", 0); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/plugins/elements/gstfakesink.c b/plugins/elements/gstfakesink.c index 6778cfb..a1c3eae 100644 --- a/plugins/elements/gstfakesink.c +++ b/plugins/elements/gstfakesink.c @@ -255,6 +255,7 @@ gst_fakesink_set_property (GObject * object, guint prop_id, sink->signal_handoffs = g_value_get_boolean (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } @@ -346,10 +347,10 @@ gst_fakesink_chain (GstPad * pad, GstData * _data) fakesink->last_message = g_strdup_printf ("chain ******* (%s:%s)< (%d bytes, timestamp: %" - G_GINT64_FORMAT ", duration: %" G_GINT64_FORMAT ", offset: %" + GST_TIME_FORMAT ", duration: %" GST_TIME_FORMAT ", offset: %" G_GINT64_FORMAT ", flags: %d) %p", GST_DEBUG_PAD_NAME (pad), - GST_BUFFER_SIZE (buf), GST_BUFFER_TIMESTAMP (buf), - GST_BUFFER_DURATION (buf), GST_BUFFER_OFFSET (buf), + GST_BUFFER_SIZE (buf), GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buf)), + GST_TIME_ARGS (GST_BUFFER_DURATION (buf)), GST_BUFFER_OFFSET (buf), GST_BUFFER_FLAGS (buf), buf); g_object_notify (G_OBJECT (fakesink), "last_message"); diff --git a/plugins/elements/gstfakesrc.c b/plugins/elements/gstfakesrc.c index c9a44f7..00aea94 100644 --- a/plugins/elements/gstfakesrc.c +++ b/plugins/elements/gstfakesrc.c @@ -535,6 +535,7 @@ gst_fakesrc_set_property (GObject * object, guint prop_id, const GValue * value, src->dump = g_value_get_boolean (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/plugins/elements/gstfdsrc.c b/plugins/elements/gstfdsrc.c index ff884f5..11fafdf 100644 --- a/plugins/elements/gstfdsrc.c +++ b/plugins/elements/gstfdsrc.c @@ -148,6 +148,7 @@ gst_fdsrc_set_property (GObject * object, guint prop_id, const GValue * value, src->timeout = g_value_get_uint64 (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/plugins/elements/gstfilesrc.c b/plugins/elements/gstfilesrc.c index 1943b24..6ef3783 100644 --- a/plugins/elements/gstfilesrc.c +++ b/plugins/elements/gstfilesrc.c @@ -322,6 +322,7 @@ gst_filesrc_set_property (GObject * object, guint prop_id, const GValue * value, g_object_notify (G_OBJECT (src), "touch"); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/plugins/elements/gstidentity.c b/plugins/elements/gstidentity.c index 0849361..cecf0ad 100644 --- a/plugins/elements/gstidentity.c +++ b/plugins/elements/gstidentity.c @@ -214,8 +214,8 @@ gst_identity_chain (GstPad * pad, GstData * _data) g_free (identity->last_message); identity->last_message = g_strdup_printf ("chain ******* (%s:%s)i (%d bytes, %" - G_GINT64_FORMAT ")", GST_DEBUG_PAD_NAME (identity->sinkpad), - GST_BUFFER_SIZE (buf), GST_BUFFER_TIMESTAMP (buf)); + GST_TIME_FORMAT ")", GST_DEBUG_PAD_NAME (identity->sinkpad), + GST_BUFFER_SIZE (buf), GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buf))); g_object_notify (G_OBJECT (identity), "last-message"); } @@ -299,6 +299,7 @@ gst_identity_set_property (GObject * object, guint prop_id, identity->drop_probability = g_value_get_float (value); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/plugins/elements/gstmultifilesrc.c b/plugins/elements/gstmultifilesrc.c index 156771a..7855efc 100644 --- a/plugins/elements/gstmultifilesrc.c +++ b/plugins/elements/gstmultifilesrc.c @@ -157,6 +157,7 @@ gst_multifilesrc_set_property (GObject * object, guint prop_id, } break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } diff --git a/plugins/elements/gstpipefilter.c b/plugins/elements/gstpipefilter.c index ec5d887..c141186 100644 --- a/plugins/elements/gstpipefilter.c +++ b/plugins/elements/gstpipefilter.c @@ -237,6 +237,7 @@ gst_pipefilter_set_property (GObject * object, guint prop_id, pipefilter->command = g_strsplit (g_value_get_string (value), " ", 0); break; default: + G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; } } -- 2.7.4