From 5a21d2bbb982e431fe0512af2438a1a5e1e13c29 Mon Sep 17 00:00:00 2001
From: Christian Sigg <csigg@google.com>
Date: Fri, 31 Jan 2020 12:19:36 +0100
Subject: [PATCH] Rename prettyprinters test to llvm-support.

Summary: Make room for mlir-support pretty printers that I would like to add next.

Reviewers: dblaikie

Reviewed By: dblaikie

Subscribers: merge_guards_bot, mgorny, rriddle, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73726
---
 debuginfo-tests/CMakeLists.txt                                    | 8 ++++----
 .../gdb/{prettyprinters.cpp => llvm-support.cpp}                  | 4 ++++
 .../gdb/{prettyprinters.gdb => llvm-support.gdb}                  | 2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)
 rename debuginfo-tests/llvm-prettyprinters/gdb/{prettyprinters.cpp => llvm-support.cpp} (90%)
 rename debuginfo-tests/llvm-prettyprinters/gdb/{prettyprinters.gdb => llvm-support.gdb} (97%)

diff --git a/debuginfo-tests/CMakeLists.txt b/debuginfo-tests/CMakeLists.txt
index c122d9b..9f488e9 100644
--- a/debuginfo-tests/CMakeLists.txt
+++ b/debuginfo-tests/CMakeLists.txt
@@ -2,10 +2,10 @@
 # various types of debug info, and then run those programs under a debugger
 # such as GDB or LLDB to verify the results.
 
-add_llvm_executable(prettyprinters
-        llvm-prettyprinters/gdb/prettyprinters.cpp
+add_llvm_executable(check-gdb-llvm-support
+        llvm-prettyprinters/gdb/llvm-support.cpp
 )
-target_link_libraries(prettyprinters PRIVATE LLVMSupport)
+target_link_libraries(check-gdb-llvm-support PRIVATE LLVMSupport)
 
 set(DEBUGINFO_TESTS_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 set(DEBUGINFO_TESTS_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
@@ -15,8 +15,8 @@ set(DEBUGINFO_TEST_DEPS
   FileCheck
   count
   llvm-objdump
+  check-gdb-llvm-support
   not
-  prettyprinters
   )
 
 # The Windows builder scripts pass -fuse-ld=lld.
diff --git a/debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.cpp b/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp
similarity index 90%
rename from debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.cpp
rename to debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp
index ed556ec..7e0f193 100644
--- a/debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.cpp
+++ b/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp
@@ -47,4 +47,8 @@ auto SimpleIlist = []() {
   return Result;
 }();
 
+// Check expected instances to avoid compile errors.
+auto CheckExpectedValue = static_cast<bool>(ExpectedValue);
+auto CheckExpectedError = static_cast<bool>(ExpectedError);
+
 int main() { return 0; }
diff --git a/debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.gdb b/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.gdb
similarity index 97%
rename from debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.gdb
rename to debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.gdb
index 12baa6e..c02c03c 100644
--- a/debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.gdb
+++ b/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.gdb
@@ -1,4 +1,4 @@
-# RUN: gdb -q -batch -n -iex 'source %llvm_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/prettyprinters | FileCheck %s
+# RUN: gdb -q -batch -n -iex 'source %llvm_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/check-gdb-llvm-support | FileCheck %s
 
 break main
 run
-- 
2.7.4