From 5a123c4e37d9969a7c1a0d2b470db9330267817b Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 16 Aug 2016 09:36:29 +0000 Subject: [PATCH] Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class Despite its comment, the function is only used in the Client class, and its presence was merely complicating mock implementation in unit tests. llvm-svn: 278785 --- .../Plugins/Process/gdb-remote/GDBRemoteCommunication.h | 6 ------ .../Process/gdb-remote/GDBRemoteCommunicationClient.h | 2 +- .../Process/gdb-remote/GDBRemoteCommunicationServerCommon.h | 6 ------ .../unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp | 12 ------------ 4 files changed, 1 insertion(+), 25 deletions(-) diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h index 623f0d1..5eb1f29 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h @@ -126,12 +126,6 @@ public: } //------------------------------------------------------------------ - // Client and server must implement these pure virtual functions - //------------------------------------------------------------------ - virtual bool - GetThreadSuffixSupported () = 0; - - //------------------------------------------------------------------ // Set the global packet timeout. // // For clients, this is the timeout that gets used when sending diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h index 424a949..83502f4 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h @@ -65,7 +65,7 @@ public: std::string &response_string); bool - GetThreadSuffixSupported () override; + GetThreadSuffixSupported(); // This packet is usually sent first and the boolean return value // indicates if the packet was send and any response was received diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h index d2fd700..7bb6726 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h @@ -176,12 +176,6 @@ protected: }); } - bool - GetThreadSuffixSupported () override - { - return true; - } - //------------------------------------------------------------------ /// Launch a process with the current launch settings. /// diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp index be67114..596391c 100644 --- a/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp +++ b/lldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp @@ -60,12 +60,6 @@ struct MockServer : public GDBRemoteCommunicationServer { MockServer() : GDBRemoteCommunicationServer("mock-server", "mock-server.listener") { m_send_acks = false; } - bool - GetThreadSuffixSupported() override - { - return false; - } - PacketResult SendPacket(llvm::StringRef payload) { @@ -84,12 +78,6 @@ struct MockServer : public GDBRemoteCommunicationServer struct TestClient : public GDBRemoteClientBase { TestClient() : GDBRemoteClientBase("test.client", "test.client.listener") { m_send_acks = false; } - - bool - GetThreadSuffixSupported() override - { - return false; - } }; struct ContinueFixture -- 2.7.4