From 5a06fa726679f88c0a0426b9671e981d20f9536e Mon Sep 17 00:00:00 2001 From: "ws29.jung" Date: Tue, 14 Apr 2020 16:39:33 +0900 Subject: [PATCH] [Addon] Fix showMessageBox function Old version of Electron only had 'showMessageBox' function, and it handled sync and async mode under binded C++ function. Now new Electron export 'showMessageBoxSync' function separatly and it works as sync mode of old 'showMessageBox'. To handle both functions with one source code, this patch makes addonapi method to use logical function fallback. Change-Id: I97c06ebff302c7e3770166fe162c53ea251f05b0 Signed-off-by: ws29.jung --- wrt_app/addon/browser/modules/window.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/wrt_app/addon/browser/modules/window.js b/wrt_app/addon/browser/modules/window.js index c7a92f2..44e779d 100644 --- a/wrt_app/addon/browser/modules/window.js +++ b/wrt_app/addon/browser/modules/window.js @@ -10,11 +10,12 @@ module.exports = { showMessageBox: function (winId, options) { let window = TopLevelWindow.fromId(winId); - dialog.showMessageBox(window, options, null); + let showMessageBox = (dialog.showMessageBoxSync || dialog.showMessageBox); + showMessageBox(window, options); }, show: function (winId) { let window = TopLevelWindow.fromId(winId); window.show(); } -} \ No newline at end of file +} -- 2.7.4