From 59f586ba59945e2ea1275748575ad45745ce526b Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Sun, 24 Nov 2013 23:17:48 +0800 Subject: [PATCH] Use "Atom-Shell" instead of "atom-shell" for product names. --- atom.gyp | 2 +- common/crash_reporter/crash_reporter_mac.mm | 2 +- common/crash_reporter/crash_reporter_win.cc | 2 +- spec/fixtures/api/crash.html | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/atom.gyp b/atom.gyp index 4bb0dfc..d0aaefa 100644 --- a/atom.gyp +++ b/atom.gyp @@ -420,7 +420,7 @@ 'tools/mac/generate_breakpad_symbols.py', '--build-dir=<(PRODUCT_DIR)', '--binary=<(PRODUCT_DIR)/<(product_name).app/Contents/MacOS/<(product_name)', - '--symbols-dir=<(PRODUCT_DIR)/atom-shell.breakpad.syms', + '--symbols-dir=<(PRODUCT_DIR)/Atom-Shell.breakpad.syms', '--clear', '--jobs=16', ], diff --git a/common/crash_reporter/crash_reporter_mac.mm b/common/crash_reporter/crash_reporter_mac.mm index f3ab45d..dac77e7 100644 --- a/common/crash_reporter/crash_reporter_mac.mm +++ b/common/crash_reporter/crash_reporter_mac.mm @@ -31,7 +31,7 @@ void CrashReporterMac::InitBreakpad(const std::string& product_name, NSMutableDictionary* parameters = [NSMutableDictionary dictionaryWithCapacity:4]; - [parameters setValue:@"atom-shell" + [parameters setValue:@"Atom-Shell" forKey:@BREAKPAD_PRODUCT]; [parameters setValue:base::SysUTF8ToNSString(product_name) forKey:@BREAKPAD_PRODUCT_DISPLAY]; diff --git a/common/crash_reporter/crash_reporter_win.cc b/common/crash_reporter/crash_reporter_win.cc index 39837ec..e62986b0 100644 --- a/common/crash_reporter/crash_reporter_win.cc +++ b/common/crash_reporter/crash_reporter_win.cc @@ -100,7 +100,7 @@ google_breakpad::CustomClientInfo* CrashReporterWin::GetCustomInfo( custom_info_entries_.reserve(2 + upload_parameters_.size()); custom_info_entries_.push_back(google_breakpad::CustomInfoEntry( - L"prod", UTF8ToWide(product_name).c_str())); + L"prod", L"Atom-Shell")); custom_info_entries_.push_back(google_breakpad::CustomInfoEntry( L"ver", UTF8ToWide(version).c_str())); diff --git a/spec/fixtures/api/crash.html b/spec/fixtures/api/crash.html index 8933288..b0c3664 100644 --- a/spec/fixtures/api/crash.html +++ b/spec/fixtures/api/crash.html @@ -3,6 +3,7 @@