From 59d5680310084398dc6eb8fa62d56a7d1c9b85e0 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sun, 13 Jan 2013 23:44:01 +0100 Subject: [PATCH] h264: Fix assignments in if() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes null pointer dereference later, since if this function failed, a positive return value was returned to the caller. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Martin Storsjö --- libavcodec/h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 3660597..f1cac2c 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -2527,7 +2527,7 @@ static int h264_slice_header_init(H264Context *h, int reinit) return ret; } } else { - if ((ret = ff_MPV_common_init(s) < 0)) { + if ((ret = ff_MPV_common_init(s)) < 0) { av_log(h->s.avctx, AV_LOG_ERROR, "ff_MPV_common_init() failed.\n"); return ret; } -- 2.7.4