From 596cecfdec5a490168f82ca0d9b37ebaa3cfa3d1 Mon Sep 17 00:00:00 2001 From: YunheeHwang Date: Wed, 29 Mar 2017 18:45:47 +0900 Subject: [PATCH] Fix defect detected by static code analyzer Problem : Dynamic memory referenced by (*set)->actionsetName was allocated by calling malloc and lost without free before exit Resolve : add OCFREE((*set)->actionsetName) before OCFREE(*set) Problem : Dynamic memory referenced by payload was allocated by calling function 'OCRepPayloadCreate' and lost without free before exit Resolve : add OCRepPayloadDestroy(payload) to free them Change-Id: I2f8bbbd009c567cda8c091ffde925f1692416c9b Signed-off-by: YunheeHwang Reviewed-on: https://gerrit.iotivity.org/gerrit/18259 Tested-by: jenkins-iotivity Reviewed-by: Dan Mihai --- resource/csdk/stack/src/oicgroup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/resource/csdk/stack/src/oicgroup.c b/resource/csdk/stack/src/oicgroup.c index 881f838..3f0a6ac 100755 --- a/resource/csdk/stack/src/oicgroup.c +++ b/resource/csdk/stack/src/oicgroup.c @@ -736,6 +736,7 @@ exit: OCFREE(desc) OCFREE(capa) OCFREE(action) + OCFREE((*set)->actionsetName) OCFREE(*set) OCFREE(key) OCFREE(value) @@ -1198,6 +1199,7 @@ OCStackResult BuildCollectionGroupActionCBORResponse( stackRet = OC_STACK_ERROR; } } + OCRepPayloadDestroy(payload); } else if (method == OC_REST_POST) { @@ -1376,6 +1378,7 @@ OCStackResult BuildCollectionGroupActionCBORResponse( stackRet = OC_STACK_ERROR; } } + OCRepPayloadDestroy(payload); } exit: -- 2.7.4