From 592f9d271caaa22a6b299cfaaf6ce3394796e0e2 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Wed, 24 Apr 2019 17:50:40 +0100 Subject: [PATCH] gdb: Update type of lower bound in value_subscripted_rvalue The dynamic lower (and upper) bounds of ranges are stored as type LONGEST (see union dynamic_prop_data in gdbtypes.h). In most places that range bounds are handled they are held in a LONGEST, however in value_subscripted_rvalue the bound is placed into an int. This commit changes value_subscripted_rvalue to use LONGEST, there should be no user visible changes after this commit. gdb/ChangeLog: * valarith.c (value_subscripted_rvalue): Change lowerbound parameter type from int to LONGEST. * value.h (value_subscripted_rvalue): Likewise in declaration. --- gdb/ChangeLog | 6 ++++++ gdb/valarith.c | 2 +- gdb/value.h | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 90af6d3..33cff4e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-07-12 Andrew Burgess + + * valarith.c (value_subscripted_rvalue): Change lowerbound + parameter type from int to LONGEST. + * value.h (value_subscripted_rvalue): Likewise in declaration. + 2019-07-11 Andrew Burgess * cli/cli-utils.c (info_print_command_completer): New function. diff --git a/gdb/valarith.c b/gdb/valarith.c index 4ee7f24..8f3c502 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -183,7 +183,7 @@ value_subscript (struct value *array, LONGEST index) to doubles, but no longer does. */ struct value * -value_subscripted_rvalue (struct value *array, LONGEST index, int lowerbound) +value_subscripted_rvalue (struct value *array, LONGEST index, LONGEST lowerbound) { struct type *array_type = check_typedef (value_type (array)); struct type *elt_type = check_typedef (TYPE_TARGET_TYPE (array_type)); diff --git a/gdb/value.h b/gdb/value.h index 9f55408..47bf672 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -1152,7 +1152,8 @@ extern struct value *find_function_in_inferior (const char *, extern struct value *value_allocate_space_in_inferior (int); extern struct value *value_subscripted_rvalue (struct value *array, - LONGEST index, int lowerbound); + LONGEST index, + LONGEST lowerbound); /* User function handler. */ -- 2.7.4