From 58ed9c91679dc81406de8ff4bcd53f4b40ebbbee Mon Sep 17 00:00:00 2001 From: Daniel Jasper Date: Mon, 21 Jul 2014 06:06:38 +0000 Subject: [PATCH] clang-tidy: [misc-use-override] Slightly tweak the wording of warning. 'final' should really be used with care. llvm-svn: 213501 --- clang-tools-extra/clang-tidy/misc/UseOverride.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp index d1a9e2f..685750e 100644 --- a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp +++ b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp @@ -71,11 +71,11 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) { if (!OnlyVirtualSpecified && KeywordCount == 1) return; // Nothing to do. - DiagnosticBuilder Diag = - diag(Method->getLocation(), - OnlyVirtualSpecified - ? "Prefer using 'override' or 'final' instead of 'virtual'" - : "Use exactly one of 'virtual', 'override' and 'final'"); + DiagnosticBuilder Diag = diag( + Method->getLocation(), + OnlyVirtualSpecified + ? "Prefer using 'override' or 'final' instead of 'virtual'" + : "Use exactly one of 'virtual', 'override' or (rarely) 'final'"); CharSourceRange FileRange = Lexer::makeFileCharRange( CharSourceRange::getTokenRange(Method->getSourceRange()), Sources, -- 2.7.4