From 589ce7561a386b1dccf657f575f506f43b93c03c Mon Sep 17 00:00:00 2001
From: "yangguo@chromium.org"
 <yangguo@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Date: Wed, 28 Sep 2011 14:26:23 +0000
Subject: [PATCH] Fixing test case from r9469.

Review URL: http://codereview.chromium.org/8038046

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
---
 test/cctest/test-debug.cc   | 24 ------------------------
 test/cctest/test-threads.cc | 20 ++++++++++++++++++--
 2 files changed, 18 insertions(+), 26 deletions(-)

diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 2383f2dd0..de60d4999 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -5845,14 +5845,11 @@ TEST(DebuggerAgent) {
   const int kPort1 = 5858;
   const int kPort2 = 5857;
   const int kPort3 = 5856;
-  const int kPort4 = 5855;
 
   // Make a string with the port2 number.
   const int kPortBufferLen = 6;
   char port2_str[kPortBufferLen];
   OS::SNPrintF(i::Vector<char>(port2_str, kPortBufferLen), "%d", kPort2);
-  char port4_str[kPortBufferLen];
-  OS::SNPrintF(i::Vector<char>(port4_str, kPortBufferLen), "%d", kPort4);
 
   bool ok;
 
@@ -5888,27 +5885,6 @@ TEST(DebuggerAgent) {
   debugger->StopAgent();
 
   delete server;
-
-  // Test responsiveness after connecting and disconnecting a client.
-  ok = debugger->StartAgent("test", kPort4);
-  CHECK(ok);
-  client = i::OS::CreateSocket();
-  ok = client->Connect("localhost", port4_str);
-  CHECK(ok);
-  ok = client->Receive(&buf, 1) == 1;
-  CHECK(ok);
-  ok = client->Send(
-      "{\"seq\":1,\"type\":\"request\",\"command\":\"disconnect\"}", 49);
-  CHECK(ok);
-  client->Shutdown();
-  delete client;
-  // Is the server still responsive?
-  client = i::OS::CreateSocket();
-  ok = client->Connect("localhost", port4_str);
-  CHECK(ok);
-  client->Shutdown();
-  delete client;
-  debugger->StopAgent();
 }
 
 
diff --git a/test/cctest/test-threads.cc b/test/cctest/test-threads.cc
index e1a48ae53..713d1e842 100644
--- a/test/cctest/test-threads.cc
+++ b/test/cctest/test-threads.cc
@@ -63,7 +63,7 @@ enum Turn {
 static Turn turn = FILL_CACHE;
 
 
-class ThreadA: public v8::internal::Thread {
+class ThreadA : public v8::internal::Thread {
  public:
   ThreadA() : Thread("ThreadA") { }
   void Run() {
@@ -99,7 +99,7 @@ class ThreadA: public v8::internal::Thread {
 };
 
 
-class ThreadB: public v8::internal::Thread {
+class ThreadB : public v8::internal::Thread {
  public:
   ThreadB() : Thread("ThreadB") { }
   void Run() {
@@ -190,3 +190,19 @@ TEST(ThreadIdValidation) {
     delete threads[i];
   }
 }
+
+
+class ThreadC : public v8::internal::Thread {
+ public:
+  ThreadC() : Thread("ThreadC") { }
+  void Run() {
+    Join();
+  }
+};
+
+
+TEST(ThreadJoinSelf) {
+  ThreadC thread;
+  thread.Start();
+  thread.Join();
+}
-- 
2.34.1