From 58425d2a87d55ec67b92d152eb276df73ba5ef14 Mon Sep 17 00:00:00 2001 From: Michal Bloch Date: Mon, 19 Apr 2021 12:43:34 +0200 Subject: [PATCH] Address some static analysis complaints Change-Id: I365afab682da1f86edde0a59b3e309e951c503be Signed-off-by: Michal Bloch --- src/logger/qos.c | 3 ++- src/logger/reader_logger.c | 4 +++- src/logger/reader_pipe.c | 5 ++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/logger/qos.c b/src/logger/qos.c index 9f47d28..c780beb 100644 --- a/src/logger/qos.c +++ b/src/logger/qos.c @@ -101,7 +101,8 @@ void qos_add_log(struct qos_module *qos, const struct dlogutil_entry *due) assert(qos->threshold > 0); assert(qos->file_path); - metrics_add_log(qos->log_metrics, due); + if (!metrics_add_log(qos->log_metrics, due)) + return; const int diff = metrics_get_total(qos->log_metrics) - qos->threshold; if (diff < 0) diff --git a/src/logger/reader_logger.c b/src/logger/reader_logger.c index 8f26042..7c204ee 100644 --- a/src/logger/reader_logger.c +++ b/src/logger/reader_logger.c @@ -30,7 +30,9 @@ static void subreader_logger_file_apply_log(const struct subreader_logger *srl, struct subreader_logger_file *const srlf = (struct subreader_logger_file *) srl->sub_userdata; assert(srlf); - logfile_write_with_rotation(due, &srlf->file, DLOGUTIL_SORT_SENT_REAL); + if (logfile_write_with_rotation(due, &srlf->file, DLOGUTIL_SORT_SENT_REAL)) { + // ignore errors, can't do anything about them + } } static void subreader_logger_file_free(void *userdata) diff --git a/src/logger/reader_pipe.c b/src/logger/reader_pipe.c index 7f158d1..6e16516 100644 --- a/src/logger/reader_pipe.c +++ b/src/logger/reader_pipe.c @@ -121,7 +121,10 @@ int reader_print_out_single_log(struct reader_pipe *reader, const dlogutil_entry return 0; if (reader->file.path) { - logfile_write_with_rotation(dlogutil_entry, &reader->file, reader->buf_ptr->sort_by); + if (logfile_write_with_rotation(dlogutil_entry, &reader->file, reader->buf_ptr->sort_by)) { + // ignore, can't do much about it + } + return 0; } -- 2.7.4