From 581c1b14394aee60aff46ea67d05483261ed6527 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Mon, 31 Oct 2005 09:23:54 +0100 Subject: [PATCH] [PATCH] noop-iosched: avoid corrupted request merging Tejun Heo notes: "I'm currently debugging this. The problem is that we are using the generic dispatch queue directly in the noop sched and merging is NOT allowed on dispatch queues but generic handling of last_merge tries to merge requests. I'm still trying to verify this, so I'll be back with results soon." In the meantime, disable merging for noop by setting REQ_NOMERGE in elevator_noop_add_request(). Eventually, we should add a noop_list and do the dispatching like in the other io schedulers. Merging is still beneficial for noop (and it has always done it). Signed-off-by: Jens Axboe Signed-off-by: Linus Torvalds --- drivers/block/noop-iosched.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/noop-iosched.c b/drivers/block/noop-iosched.c index f56b8ed..e54f006 100644 --- a/drivers/block/noop-iosched.c +++ b/drivers/block/noop-iosched.c @@ -9,6 +9,7 @@ static void elevator_noop_add_request(request_queue_t *q, struct request *rq) { + rq->flags |= REQ_NOMERGE; elv_dispatch_add_tail(q, rq); } -- 2.7.4