From 57b6b175adf4c6fd4737c72142b6d8d220a17622 Mon Sep 17 00:00:00 2001 From: Panu Matilainen Date: Sat, 28 Jan 2012 17:23:16 +0200 Subject: [PATCH] xcalloc() cannot return NULL, remove redundant check --- lib/rpmfi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/rpmfi.c b/lib/rpmfi.c index ae5643c..3abd60e 100644 --- a/lib/rpmfi.c +++ b/lib/rpmfi.c @@ -1121,7 +1121,7 @@ static scidx_t *cacheTag(strcache cache, Header h, rpmTag tag) rpmfi rpmfiNew(const rpmts ts, Header h, rpmTagVal tagN, rpmfiFlags flags) { - rpmfi fi = NULL; + rpmfi fi = xcalloc(1, sizeof(*fi)); unsigned char * t; struct rpmtd_s fdigests, digalgo; struct rpmtd_s td; @@ -1129,10 +1129,6 @@ rpmfi rpmfiNew(const rpmts ts, Header h, rpmTagVal tagN, rpmfiFlags flags) HEADERGET_MINMEM : HEADERGET_ALLOC; headerGetFlags defFlags = HEADERGET_ALLOC; - fi = xcalloc(1, sizeof(*fi)); - if (fi == NULL) /* XXX can't happen */ - goto exit; - fi->magic = RPMFIMAGIC; fi->i = -1; -- 2.7.4