From 577f07f6b1640977c0bbae5bbd5f0617b7917e06 Mon Sep 17 00:00:00 2001 From: Adeel Date: Mon, 25 Feb 2019 04:40:06 -0800 Subject: [PATCH] Address janvorli's feedback comments Commit migrated from https://github.com/dotnet/coreclr/commit/805c8b231e0b8354b3997e81a779604fa1897c4e --- src/coreclr/src/debug/createdump/datatarget.cpp | 4 ++-- src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp | 2 +- .../tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/coreclr/src/debug/createdump/datatarget.cpp b/src/coreclr/src/debug/createdump/datatarget.cpp index 9345450..35b582e 100644 --- a/src/coreclr/src/debug/createdump/datatarget.cpp +++ b/src/coreclr/src/debug/createdump/datatarget.cpp @@ -150,8 +150,8 @@ DumpDataTarget::ReadVirtual( /* [optional][out] */ ULONG32 *done) { assert(m_fd != -1); - size_t read = pread64(m_fd, buffer, size, (off64_t)(ULONG_PTR)address); - if (read == (size_t)-1) + ssize_t read = pread64(m_fd, buffer, size, (off64_t)(ULONG_PTR)address); + if (read == -1) { *done = 0; return E_FAIL; diff --git a/src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp b/src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp index 875d580..3502cbf 100644 --- a/src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp +++ b/src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp @@ -10,7 +10,7 @@ DECIMAL g_DECIMAL_MaxValue = { 0, {{ 0, 0 }}, static_cast(0xffffffff), {{st DECIMAL g_DECIMAL_MinValue = { 0, {{ 0, DECIMAL_NEG }}, static_cast(0xffffffff), {{static_cast(0xffffffff), static_cast(0xffffffff)}} }; DECIMAL g_DECIMAL_Zero = { 0 }; -CY g_CY_MaxValue = { { static_cast(0xffffffff), static_cast(0x7fffffff) } }; +CY g_CY_MaxValue = { { static_cast(0xffffffff), 0x7fffffff} }; CY g_CY_MinValue = { { (LONG)0x00000000, (LONG)0x80000000 } }; CY g_CY_Zero = { { 0 } }; diff --git a/src/coreclr/tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp b/src/coreclr/tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp index d586bfa..d28b631 100644 --- a/src/coreclr/tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp +++ b/src/coreclr/tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp @@ -10,7 +10,7 @@ DECIMAL g_DECIMAL_MaxValue = { 0, {{ 0, 0 }}, static_cast(0xffffffff), {{st DECIMAL g_DECIMAL_MinValue = { 0, {{ 0, DECIMAL_NEG }}, static_cast(0xffffffff), {{static_cast(0xffffffff), static_cast(0xffffffff) }}}; DECIMAL g_DECIMAL_Zero = { 0 }; -CY g_CY_MaxValue = { {static_cast(0xffffffff), static_cast(0x7fffffff)} }; +CY g_CY_MaxValue = { {static_cast(0xffffffff), 0x7fffffff} }; CY g_CY_MinValue = { {(LONG)0x00000000, (LONG)0x80000000} }; CY g_CY_Zero = { {0} }; -- 2.7.4