From 56894fb10ad6a3e8c23e7b58ca4aa3b36754e5a4 Mon Sep 17 00:00:00 2001 From: David Herrmann Date: Thu, 6 Dec 2012 15:21:23 +0100 Subject: [PATCH] cdev: change TODO item to check for CAP_KILL CAP_KILL will be documented in kmscon manuals, but we should actually check for the capability during startup. However, this requires linking with libcap or libcap-ng and we currently want to avoid that for such a simple task. Signed-off-by: David Herrmann --- src/kmscon_cdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/kmscon_cdev.c b/src/kmscon_cdev.c index e80f676..845e09b 100644 --- a/src/kmscon_cdev.c +++ b/src/kmscon_cdev.c @@ -360,7 +360,7 @@ static int client_activate(struct cdev_client *client) int ret; struct cdev_waiter *waiter; - /* TODO: Document that CAP_KILL is needed for this to work properly */ + /* TODO: Check whether we have CAP_KILL capability during startup */ if (client->vtmode.mode == VT_PROCESS && client->vtmode.acqsig) { ret = kill(client->user.pid, client->vtmode.acqsig); if (ret) @@ -385,7 +385,6 @@ static int client_deactivate(struct cdev_client *client) { int ret; - /* TODO: Document that CAP_KILL is needed for this to work properly */ if (client->vtmode.mode == VT_PROCESS && client->vtmode.relsig) { ret = kill(client->user.pid, client->vtmode.relsig); if (ret) -- 2.7.4