From 55f8b2543a36734377c4000bde6198b1dcb42d4b Mon Sep 17 00:00:00 2001 From: Barry Song Date: Sat, 12 Sep 2020 21:40:36 +1200 Subject: [PATCH] dmaengine: zx: remove redundant irqsave in hardIRQ Running in hardIRQ context, disabling IRQ is redundant. Cc: Jun Nie Cc: Shawn Guo Cc: Dan Williams Cc: Vinod Koul Signed-off-by: Barry Song Link: https://lore.kernel.org/r/20200912094036.32112-1-song.bao.hua@hisilicon.com Signed-off-by: Vinod Koul --- drivers/dma/zx_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c index 5fe2e8b..b057582 100644 --- a/drivers/dma/zx_dma.c +++ b/drivers/dma/zx_dma.c @@ -285,9 +285,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id) p = &d->phy[i]; c = p->vchan; if (c) { - unsigned long flags; - - spin_lock_irqsave(&c->vc.lock, flags); + spin_lock(&c->vc.lock); if (c->cyclic) { vchan_cyclic_callback(&p->ds_run->vd); } else { @@ -295,7 +293,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id) p->ds_done = p->ds_run; task = 1; } - spin_unlock_irqrestore(&c->vc.lock, flags); + spin_unlock(&c->vc.lock); irq_chan |= BIT(i); } } -- 2.7.4