From 55ed09d32e2602eba1dbb8aba1985246739c3909 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Mon, 30 Mar 2020 13:58:18 -0700 Subject: [PATCH] Revert "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test" This reverts commit 502a06fcdafa637a9890da16c2734bc1a36010f6 as it breaks the macOS bots. Raph will take a look and re-commit. --- .../test/API/commands/expression/diagnostics/TestExprDiagnostics.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py index b5eb552..da29d7b 100644 --- a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py +++ b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py @@ -60,10 +60,10 @@ class ExprDiagnosticsTestCase(TestBase): self.assertIn(":1:10", value.GetError().GetCString()) # Multiline top-level expressions. - value = frame.EvaluateExpression("void x() {}\nvoid foo;", top_level_opts) + value = frame.EvaluateExpression("void x() {}\nvoid foo(unknown_type x) {}", top_level_opts) self.assertFalse(value.GetError().Success()) - self.assertIn("\nvoid foo;\n ^", value.GetError().GetCString()) - self.assertIn(":2:6", value.GetError().GetCString()) + self.assertIn("\nvoid foo(unknown_type x) {}\n ^\n", value.GetError().GetCString()) + self.assertIn(":2:10", value.GetError().GetCString()) # Test that we render Clang's 'notes' correctly. value = frame.EvaluateExpression("struct SFoo{}; struct SFoo { int x; };", top_level_opts) -- 2.7.4