From 559834827237ef06524c27a029e3253bd6f55158 Mon Sep 17 00:00:00 2001 From: "verwaest@chromium.org" Date: Tue, 19 Aug 2014 08:14:01 +0000 Subject: [PATCH] Revert "Get rid of dead version of GetNormalizedProperty" (Doh, landed too early) R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/487163002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/objects.cc | 16 ++++++++++++++++ src/objects.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/src/objects.cc b/src/objects.cc index f542480..52f858f 100644 --- a/src/objects.cc +++ b/src/objects.cc @@ -630,6 +630,22 @@ Object* JSObject::GetNormalizedProperty(const LookupResult* result) { } +Handle JSObject::GetNormalizedProperty(Handle object, + const LookupResult* result) { + DCHECK(!object->HasFastProperties()); + Isolate* isolate = object->GetIsolate(); + Handle value( + object->property_dictionary()->ValueAt(result->GetDictionaryEntry()), + isolate); + if (object->IsGlobalObject()) { + value = handle(Handle::cast(value)->value(), isolate); + DCHECK(!value->IsTheHole()); + } + DCHECK(!value->IsPropertyCell() && !value->IsCell()); + return value; +} + + void JSObject::SetNormalizedProperty(Handle object, Handle name, Handle value, diff --git a/src/objects.h b/src/objects.h index a954aab..9306090 100644 --- a/src/objects.h +++ b/src/objects.h @@ -2157,6 +2157,8 @@ class JSObject: public JSReceiver { // Retrieve a value in a normalized object given a lookup result. // Handles the special representation of JS global objects. Object* GetNormalizedProperty(const LookupResult* result); + static Handle GetNormalizedProperty(Handle object, + const LookupResult* result); // Sets the property value in a normalized object given (key, value, details). // Handles the special representation of JS global objects. -- 2.7.4