From 557a19ab0fce115b66094ce68752e524af599ed9 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 29 Sep 2022 16:01:49 -0700 Subject: [PATCH] [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both high firing (tens of thousands of calls) and fast running (15 µs mean). Timers like this are noise and load for profiling systems, and can be removed. rdar://100326595 Differential Revision: https://reviews.llvm.org/D134920 --- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp index 46204ba..21ef765 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp @@ -51,8 +51,6 @@ void DWARFUnit::ExtractUnitDIENoDwoIfNeeded() { return; // Already parsed ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef()); - LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()", - GetOffset()); // Set the offset to that of the first DIE and calculate the start of the // next compilation unit header. -- 2.7.4