From 555f384c2953a59df063adde359a04ccc5815d41 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 3 Jan 2023 12:44:01 +0100 Subject: [PATCH] [Inline] Avoid branch on undef UB in tests (NFC) --- llvm/test/Transforms/Inline/inline-assume.ll | 8 ++++---- .../Transforms/Inline/inline-constexpr-addrspacecast-argument.ll | 8 ++++---- llvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/llvm/test/Transforms/Inline/inline-assume.ll b/llvm/test/Transforms/Inline/inline-assume.ll index 287a562..b1e3e72 100644 --- a/llvm/test/Transforms/Inline/inline-assume.ll +++ b/llvm/test/Transforms/Inline/inline-assume.ll @@ -6,9 +6,9 @@ %struct.Foo = type { i32, ptr } ; Test that we don't crash when inlining @bar (rdar://22521387). -define void @foo(ptr align 4 %a) { +define void @foo(i1 %c, ptr align 4 %a) { entry: - call fastcc void @bar(ptr nonnull align 4 undef) + call fastcc void @bar(i1 %c, ptr nonnull align 4 undef) ; CHECK: call void @llvm.assume(i1 undef) ; CHECK: unreachable @@ -16,11 +16,11 @@ entry: ret void } -define fastcc void @bar(ptr align 4 %a) { +define fastcc void @bar(i1 %c, ptr align 4 %a) { ; CHECK-LABEL: @bar entry: %b = getelementptr inbounds %struct.Foo, ptr %a, i32 0, i32 1 - br i1 undef, label %if.end, label %if.then.i.i + br i1 %c, label %if.end, label %if.then.i.i if.then.i.i: call void @llvm.assume(i1 undef) diff --git a/llvm/test/Transforms/Inline/inline-constexpr-addrspacecast-argument.ll b/llvm/test/Transforms/Inline/inline-constexpr-addrspacecast-argument.ll index 767a584..82fb541 100644 --- a/llvm/test/Transforms/Inline/inline-constexpr-addrspacecast-argument.ll +++ b/llvm/test/Transforms/Inline/inline-constexpr-addrspacecast-argument.ll @@ -9,16 +9,16 @@ target datalayout = "e-p3:32:32-p4:64:64-n32" ; CHECK-LABEL: @constexpr_addrspacecast_ptr_size_change( ; CHECK: load i64, ptr addrspace(4) addrspacecast (ptr addrspace(3) @lds to ptr addrspace(4)) ; CHECK-NEXT: br -define void @constexpr_addrspacecast_ptr_size_change() #0 { - %tmp0 = call i32 @foo(ptr addrspace(4) addrspacecast (ptr addrspace(3) @lds to ptr addrspace(4))) #1 +define void @constexpr_addrspacecast_ptr_size_change(i1 %c) #0 { + %tmp0 = call i32 @foo(i1 %c, ptr addrspace(4) addrspacecast (ptr addrspace(3) @lds to ptr addrspace(4))) #1 ret void } -define i32 @foo(ptr addrspace(4) %arg) #1 { +define i32 @foo(i1 %c, ptr addrspace(4) %arg) #1 { bb: %tmp = getelementptr i64, ptr addrspace(4) %arg, i64 undef %tmp1 = load i64, ptr addrspace(4) %tmp - br i1 undef, label %bb2, label %bb3 + br i1 %c, label %bb2, label %bb3 bb2: store i64 0, ptr addrspace(4) %tmp diff --git a/llvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll b/llvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll index 25e4c58..d9cc3eb 100644 --- a/llvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll +++ b/llvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll @@ -6,10 +6,10 @@ bb: br i1 %tmp, label %bb1, label %bb2 bb1: - br i1 undef, label %bb4, label %bb2 + br i1 %tmp, label %bb4, label %bb2 bb2: - br i1 undef, label %bb4, label %bb5 + br i1 %tmp, label %bb4, label %bb5 bb4: %xx1 = phi i32 [ 1, %bb1 ], [ 9, %bb2 ] -- 2.7.4