From 5545c6cff9bfb79b6306e706f43623f591d89ed3 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Tue, 16 Aug 2022 15:04:12 -0700 Subject: [PATCH] hog-lib: Fix scan-build error This fixes the following errors: profiles/input/hog-lib.c:600:19: warning: Access to field 'handle' results in a dereference of a null pointer (loaded from variable 'chr') report->handle = chr->handle; ^~~~~~~~~~~ profiles/input/hog-lib.c:637:11: warning: Access to field 'value_handle' results in a dereference of a null pointer (loaded from variable 'chr') start = chr->value_handle + 1; ^~~~~~~~~~~~~~~~~ profiles/input/hog-lib.c:1240:11: warning: Access to field 'value_handle' results in a dereference of a null pointer (loaded from variable 'chr') start = chr->value_handle + 1; ^~~~~~~~~~~~~~~~~ Signed-off-by: Manika Shrivastava Signed-off-by: Ayush Garg --- profiles/input/hog-lib.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c index 6752280..0d87c4f 100755 --- a/profiles/input/hog-lib.c +++ b/profiles/input/hog-lib.c @@ -590,6 +590,9 @@ static struct report *report_new(struct bt_hog *hog, struct gatt_char *chr) struct report *report; GSList *l; + if (!chr) + return NULL; + /* Skip if report already exists */ l = g_slist_find_custom(hog->reports, chr, report_chrc_cmp); if (l) @@ -630,6 +633,9 @@ static void external_service_char_cb(uint8_t status, GSList *chars, chr = l->data; next = l->next ? l->next->data : NULL; + if (!chr) + continue; + DBG("0x%04x UUID: %s properties: %02x", chr->handle, chr->uuid, chr->properties); @@ -1232,6 +1238,9 @@ static void char_discovered_cb(uint8_t status, GSList *chars, void *user_data) chr = l->data; next = l->next ? l->next->data : NULL; + if (!chr) + continue; + DBG("0x%04x UUID: %s properties: %02x", chr->handle, chr->uuid, chr->properties); -- 2.7.4