From 552e5f831fd22e6ebd02cf0432c5cf3cc9972e3d Mon Sep 17 00:00:00 2001 From: "ager@chromium.org" Date: Thu, 4 Sep 2008 07:13:21 +0000 Subject: [PATCH] Make Date.prototype.toTimeString and Date.prototype.toLocaleTimeString only return the time portion of the date. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/date-delay.js | 11 ++++++++++- test/mjsunit/date.js | 9 +++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/date-delay.js b/src/date-delay.js index 4faa96736..a2e9ac428 100644 --- a/src/date-delay.js +++ b/src/date-delay.js @@ -614,6 +614,15 @@ function DateToTimeString() { }; +// ECMA 262 - 15.9.5.7 +function DateToLocaleTimeString() { + var t = GetTimeFrom(this); + if ($isNaN(t)) return kInvalidDate; + var lt = LocalTime(t); + return TimeString(lt); +}; + + // ECMA 262 - 15.9.5.9 function DateGetTime() { return GetTimeFrom(this); @@ -939,7 +948,7 @@ function SetupDate() { toTimeString: DateToTimeString, toLocaleString: DateToString, toLocaleDateString: DateToDateString, - toLocaleTimeString: DateToTimeString, + toLocaleTimeString: DateToLocaleTimeString, valueOf: DateGetTime, getTime: DateGetTime, getFullYear: DateGetFullYear, diff --git a/test/mjsunit/date.js b/test/mjsunit/date.js index c2007b43f..e04c6ec0e 100644 --- a/test/mjsunit/date.js +++ b/test/mjsunit/date.js @@ -124,3 +124,12 @@ l.setUTCMilliseconds(); l.setUTCMilliseconds(2); assertTrue(isNaN(l.getUTCMilliseconds())); +// Test that toLocaleTimeString only returns the time portion of the +// date without the timezone information. +function testToLocaleTimeString() { + var d = new Date(); + var s = d.toLocaleTimeString(); + assertEquals(8, s.length); +} + +testToLocaleTimeString(); -- 2.34.1